From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8998A10E260 for ; Wed, 23 Mar 2022 16:48:44 +0000 (UTC) Date: Wed, 23 Mar 2022 17:48:40 +0100 From: Kamil Konieczny To: igt-dev@lists.freedesktop.org Message-ID: References: <20220323130653.65094-1-zbigniew.kempczynski@intel.com> <20220323130653.65094-3-zbigniew.kempczynski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220323130653.65094-3-zbigniew.kempczynski@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/i915/gem_exec_parallel: Add 48b flag to execbuf List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Zbigniew, Dnia 2022-03-23 at 14:06:53 +0100, Zbigniew Kempczyński napisał(a): > On dg2 and beyond safe alignment is bigger than on integrated so we > can enter offset range >= 2^32. Add execbuf flag which allows using > such offsets. > See note at 1/2 patch, maybe you can improve description. Reviewed-by: Kamil Konieczny > Signed-off-by: Zbigniew Kempczyński > Cc: Kamil Konieczny > --- > tests/i915/gem_exec_parallel.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tests/i915/gem_exec_parallel.c b/tests/i915/gem_exec_parallel.c > index 36bf5f742e..1dfbaa2411 100644 > --- a/tests/i915/gem_exec_parallel.c > +++ b/tests/i915/gem_exec_parallel.c > @@ -150,9 +150,10 @@ static void *thread(void *data) > batch[++i] = offset + 4*t->id; > batch[++i] = offset >> 32; > obj[0].offset = offset; > - obj[0].flags |= EXEC_OBJECT_PINNED | EXEC_OBJECT_WRITE; > + obj[0].flags |= EXEC_OBJECT_PINNED | EXEC_OBJECT_WRITE | > + EXEC_OBJECT_SUPPORTS_48B_ADDRESS; > obj[1].offset = get_offset(t->ahnd, obj[1].handle, 4096, 0); > - obj[1].flags |= EXEC_OBJECT_PINNED; > + obj[1].flags |= EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS; > gem_write(fd, obj[1].handle, 0, batch, sizeof(batch)); > } > > -- > 2.32.0 >