Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_ctx_create: Added test description for test case

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Sai,

please extend a little description of active subtest,
see below.

Dnia 2022-03-22 at 10:50:14 +0530, sai.gowtham.ch@intel.com napisał(a):
> From: Ch Sai Gowtham <sai.gowtham.ch@intel.com>
> 
> Added test and subtests description
> 
> v2: Modified description to be more precise
> 
> v3: Rebase
> 
> v4: Incorporated minor changes in description based
>     on feedback
> 
> v5: Minor alignment adjustments
> 
> Signed-off-by: Apoorva Singh <apoorva1.singh@intel.com>
> Signed-off-by: Ch Sai Gowtham <sai.gowtham.ch@intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri@intel.com>
> Cc: Dec, Katarzyna <katarzyna.dec@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Katarzyna Dec <katarzyna.dec@intel.com>
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  tests/i915/gem_ctx_create.c | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/tests/i915/gem_ctx_create.c b/tests/i915/gem_ctx_create.c
> index 44846652..6eab5bac 100644
> --- a/tests/i915/gem_ctx_create.c
> +++ b/tests/i915/gem_ctx_create.c
> @@ -36,6 +36,8 @@
>  #include "igt_rand.h"
>  #include "sw_sync.h"
>  
> +IGT_TEST_DESCRIPTION("Test the context create ioctls");
> +
>  #define ENGINE_FLAGS  (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
>  
>  static unsigned all_engines[I915_EXEC_RING_MASK + 1];
> @@ -585,6 +587,7 @@ igt_main
>  		igt_fork_hang_detector(fd);
>  	}
>  
> +	igt_describe("Test random context creation");
>  	igt_subtest("basic") {
>  		memset(&create, 0, sizeof(create));
>  		create.ctx_id = rand();
> @@ -594,41 +597,67 @@ igt_main
>  		gem_context_destroy(fd, create.ctx_id);
>  	}
>  
> +	igt_describe("Verify valid and invalid context extensions");
>  	igt_subtest("ext-param")
>  		basic_ext_param(fd);
> +
> +	igt_describe("Set, validate and execute particular context params");
>  	igt_subtest("iris-pipeline")
>  		iris_pipeline(fd);
>  
> +	igt_describe("Create contexts upto available RAM size, calculate the average "
> +		     "performance of their execution on multiple parallel processes");
>  	igt_subtest("maximum-mem")
>  		maximum(fd, &cfg, ncpus, CHECK_RAM);
> +
> +	igt_describe("Create contexts upto available RAM+SWAP size, calculate the average "
> +		     "performance of their execution on multiple parallel processes");
>  	igt_subtest("maximum-swap")
>  		maximum(fd, &cfg, ncpus, CHECK_RAM | CHECK_SWAP);
>  
> +	igt_describe("Exercise implicit per-fd context creation");
>  	igt_subtest("basic-files")
>  		files(fd, &cfg, 2, 1);
> +
> +	igt_describe("Exercise implicit per-fd context creation on 1 CPU for long duration");
>  	igt_subtest("files")
>  		files(fd, &cfg, 20, 1);
> +
> +	igt_describe("Exercise implicit per-fd context creation on all CPUs for long duration");
>  	igt_subtest("forked-files")
>  		files(fd, &cfg, 20, ncpus);
>  
>  	/* NULL value means all engines */
> +	igt_describe("Calculate the average performance of context creation and "
> +		     "it's execution using all engines");
>  	igt_subtest("active-all")
>  		active(fd, &cfg, NULL, 20, 1);
> +
> +	igt_describe("Calculate the average performance of context creation and it's execution "
> +		     "using all engines on multiple parallel processes");
>  	igt_subtest("forked-active-all")
>  		active(fd, &cfg, NULL, 20, ncpus);
>  
> +	igt_describe("For each engine calculate the average performance of context creation "
> +		     "and execution");

Add "and exercise context raclaim" at end of description, e.g.
s/execution/execution and exercise context raclaim/

imho adding this here should suffice, no need to repeat it in
other active subtests.

Regards,
Kamil
>  	igt_subtest_with_dynamic("active") {
>  		for_each_ctx_cfg_engine(fd, &cfg, e) {
>  			igt_dynamic_f("%s", e->name)
>  				active(fd, &cfg, e, 20, 1);
>  		}
>  	}
> +
> +	igt_describe("For each engine calculate the average performance of context creation "
> +		     "and execution on multiple parallel processes");
>  	igt_subtest_with_dynamic("forked-active") {
>  		for_each_ctx_cfg_engine(fd, &cfg, e) {
>  			igt_dynamic_f("%s", e->name)
>  				active(fd, &cfg, e, 20, ncpus);
>  		}
>  	}
> +
> +	igt_describe("For each engine calculate the average performance of context creation "
> +		     "and execution while all other engines are hogging the resources");
>  	igt_subtest_with_dynamic("hog") {
>  		for_each_ctx_cfg_engine(fd, &cfg, e) {
>  			igt_dynamic_f("%s", e->name)
> -- 
> 2.35.1
>