Re: [igt-dev] [PATCH] i915/gem_eio: increasing the timeout for forced reset completion

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Dnia 2022-04-14 at 15:53:04 +0530, krishnaiah.bommu@intel.com napisał(a):
> From: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> 
> GUC log capture is taking more time on few platforms, so increasing the timeout
> 
> Signed-off-by: Bommu Krishnaiah <krishnaiah.bommu@intel.com>
> Cc: Konieczny Kamil <kamil.konieczny@intel.com>
-------------------------------------- ^
Please use my @linux.intel.com address.

> Cc: John Harrison <john.c.harrison@intel.com>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
>  tests/i915/gem_eio.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
> index d9689534d5a..94c3bc04644 100644
> --- a/tests/i915/gem_eio.c
> +++ b/tests/i915/gem_eio.c
> @@ -72,8 +72,11 @@ static void trigger_reset(int fd)
>  	igt_kmsg(KMSG_DEBUG "Forcing GPU reset\n");
>  	igt_force_gpu_reset(fd);
>  
> -	/* The forced reset should be immediate */
> -	igt_assert_lte(igt_seconds_elapsed(&ts), 2);
> +	/* The forced reset should be immediate, even though
> +	 * GUC log capture is taking more time on few platforms,
> +	 * so Increasing the timeout
> +	 */
> +	igt_assert_lte(igt_seconds_elapsed(&ts), 10);

Please use new timeout variable and make it 10 only for GuC
submissions, you can use:

bool gem_using_guc_submission(int fd);

from lib/i915/gem_submission.h

Later in the same function 10 is also used so imho we should
make this number lower, like 7 or increase that second one.

>  
>  	/* And just check the gpu is indeed running again */
>  	igt_kmsg(KMSG_DEBUG "Checking that the GPU recovered\n");
> -- 
> 2.25.1
>
Regards,
Kamil