From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7ED1610E319 for ; Fri, 22 Apr 2022 10:17:52 +0000 (UTC) Date: Fri, 22 Apr 2022 06:17:46 -0400 From: Rodrigo Vivi To: Anshuman Gupta Message-ID: References: <20220418125048.7969-1-anshuman.gupta@intel.com> <20220418125048.7969-5-anshuman.gupta@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220418125048.7969-5-anshuman.gupta@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 4/9] lib/intel_device_info: Add IS_DGFX() support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, badal.nilawar@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Mon, Apr 18, 2022 at 06:20:43PM +0530, Anshuman Gupta wrote: > Currently IGT is lacking IS_DGFX() macro support. > There are some power features like D3Cold are only > supported on discrete card. So IGT test/tools specific > to D3Cold requires to consume IS_DGFX(). > Adding a is_dgfx field in intel_device_info and initializing > it for DG1. All future discrete platform would require to > initialize this field. > > Cc: Rodrigo Vivi > Signed-off-by: Anshuman Gupta Reviewed-by: Rodrigo Vivi we also need this one for other stuff, so probably better to split and already merge this... > --- > lib/intel_chipset.h | 2 ++ > lib/intel_device_info.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h > index db75a829f..07fdd213e 100644 > --- a/lib/intel_chipset.h > +++ b/lib/intel_chipset.h > @@ -42,6 +42,7 @@ struct intel_device_info { > unsigned gt; /* 0 if unknown */ > bool has_4tile : 1; > bool has_flatccs; > + bool is_dgfx :1; > bool is_mobile : 1; > bool is_whitney : 1; > bool is_almador : 1; > @@ -208,6 +209,7 @@ void intel_check_pch(void); > > #define IS_MOBILE(devid) (intel_get_device_info(devid)->is_mobile) > #define IS_965(devid) AT_LEAST_GEN(devid, 4) > +#define IS_DGFX(devid) (intel_get_device_info(devid)->is_dgfx) > > #define HAS_BSD_RING(devid) AT_LEAST_GEN(devid, 5) > #define HAS_BLT_RING(devid) AT_LEAST_GEN(devid, 6) > diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c > index e55841df5..b735f16a6 100644 > --- a/lib/intel_device_info.c > +++ b/lib/intel_device_info.c > @@ -386,6 +386,7 @@ static const struct intel_device_info intel_rocketlake_info = { > static const struct intel_device_info intel_dg1_info = { > .graphics_ver = 12, > .display_ver = 12, > + .is_dgfx = true, > .is_dg1 = true, > .codename = "dg1" > }; > @@ -394,6 +395,7 @@ static const struct intel_device_info intel_dg2_info = { > .graphics_ver = 12, > .display_ver = 13, > .has_4tile = true, > + .is_dgfx = true, > .is_dg2 = true, > .codename = "dg2", > .has_flatccs = true, > -- > 2.26.2 >