Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_madvise: added description for test case

[Kamil Konieczny <kamil.konieczny@linux.intel.com>]

Hi Priyanka,

On 2022-04-25 at 15:01:35 +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Added test description for subtest.
------- ^--------------- ^ --------- ^
Drop s/test/ and please use plural here:

Added descriptions for subtests.

> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: ranjeet kumar <ranjeet1.kumar@intel.com>
---------------- ^ ----- ^
Please change this into capital letters:

Signed-off-by: Ranjeet Kumar <ranjeet1.kumar@intel.com>

With that fixed you can add my r-b tag.

Regards,
Kamil

> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Acked-by: Katarzyna Dec <katarzyna.dec@intel.com>
> ---
>  tests/i915/gem_madvise.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/i915/gem_madvise.c b/tests/i915/gem_madvise.c
> index d88747a9..2502d84c 100644
> --- a/tests/i915/gem_madvise.c
> +++ b/tests/i915/gem_madvise.c
> @@ -190,15 +190,23 @@ dontneed_before_exec(void)
>  
>  igt_main
>  {
> +	igt_describe("Check signal for Segmentation Fault and bus error before"
> +		     " obtaining a purgeable object and calling for sighandler.");
>  	igt_subtest("dontneed-before-mmap")
>  		dontneed_before_mmap();
>  
> +	igt_describe("Check signal for Segmentation Fault and bus error after"
> +		     " obtaining a purgeable object and calling for sighandler.");
>  	igt_subtest("dontneed-after-mmap")
>  		dontneed_after_mmap();
>  
> +	igt_describe("Check if PWRITE reports EFAULT when trying to use purged bo"
> +		     " for write operation.");
>  	igt_subtest("dontneed-before-pwrite")
>  		dontneed_before_pwrite();
>  
> +	igt_describe("Check if EXECBUFFER2 reports EFAULT when trying to submit"
> +		     " purged bo for GPU.");
>  	igt_subtest("dontneed-before-exec")
>  		dontneed_before_exec();
>  }
> -- 
> 2.25.1
>