From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9B69614ABDE for ; Mon, 11 Jul 2022 14:14:12 +0000 (UTC) Date: Mon, 11 Jul 2022 10:14:05 -0400 From: Rodrigo Vivi To: "igt-dev@lists.freedesktop.org" , "Srivatsa, Anusha" , "Gupta, Anshuman" Message-ID: References: <20220708181744.398984-1-anusha.srivatsa@intel.com> <19d53e1a0dee4cb28ddbc68ec7859d65@intel.com> <7bcf69369cce79fcf56dbfb6009579529859487b.camel@intel.com> Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7bcf69369cce79fcf56dbfb6009579529859487b.camel@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from DC9 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Mon, Jul 11, 2022 at 02:00:42PM +0000, Vivi, Rodrigo wrote: > On Mon, 2022-07-11 at 04:11 +0000, Gupta, Anshuman wrote: > > > > > > > -----Original Message----- > > > From: Srivatsa, Anusha > > > Sent: Friday, July 8, 2022 11:48 PM > > > To: igt-dev@lists.freedesktop.org > > > Cc: Srivatsa, Anusha ; Deak, Imre > > > ; Gupta, Anshuman ; > > > Vivi, > > > Rodrigo > > > Subject: [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from > > > DC9 > > > > > > Different from DC6, DC9 does not depend on BIOS/PCU to execute save > > > and > > > restore or any other sequence when going to PC9/PC10 > > Commit message should explain this is a change for all DGFX platform. > > yeap. the commit message needs to change as well. I meant to say commit subject... > > and I'd say preferably we would have that IS_DGFX patch in place and > use that instead of individual platforms. > > That patch got nacked because has_lmem is preferred, but in this > case the lmem check makes not much sense and the clean way is the > IS_DGFX. So maybe we have a good reason after all.. > > > > Thanks, > > Anshuman Gupta. > > > > > > DC9 actually depends on D3 and PCODE simply remove power if SW > > > allowed > > > > > > v2: resrict the check for igfx only. > > > > > > Cc: Imre Deak > > > Cc: Anshuman Gupta > > > Cc: Anusha Srivatsa > > > Cc: Rodrigo Vivi > > > Signed-off-by: Rodrigo Vivi > > > Signed-off-by: Anusha Srivatsa (v2) > > > --- > > >  tests/i915/i915_pm_dc.c | 5 +++-- > > >  1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c > > > index > > > a780f2cb..5132734b 100644 > > > --- a/tests/i915/i915_pm_dc.c > > > +++ b/tests/i915/i915_pm_dc.c > > > @@ -532,8 +532,9 @@ int main(int argc, char *argv[]) > > > > > >  igt_describe("This test validates display engine entry to DC9 > > > state"); > > >  igt_subtest("dc9-dpms") { > > > - > > > igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd), > > > -"PC8+ residencies not supported\n"); > > > +if (!(IS_DG1(data.devid) || IS_DG2(data.devid))) > > > + > > > igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd), > > > +      "PC8+ residencies not supported\n"); > > >  test_dc9_dpms(&data); > > >  } > > > > > > -- > > > 2.25.1 > > >