From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 256AD10E374 for ; Mon, 26 Sep 2022 09:32:36 +0000 (UTC) Date: Mon, 26 Sep 2022 12:32:32 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Bhanuprakash Modem Message-ID: References: <20220925160050.2149579-1-bhanuprakash.modem@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220925160050.2149579-1-bhanuprakash.modem@intel.com> Subject: Re: [igt-dev] [i-g-t] tests/kms_color: Fix ctm-0.* tests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Sun, Sep 25, 2022 at 09:30:50PM +0530, Bhanuprakash Modem wrote: > As we are testing with a few values around the expected result > because of the hardware rounded values, fix the logic to generate > the expected values to deal with those hardware rounding issues. > > Cc: Ville Syrjälä > Signed-off-by: Bhanuprakash Modem Reviewed-by: Ville Syrjälä > --- > tests/kms_color.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/kms_color.c b/tests/kms_color.c > index ab285af8..2804bde8 100644 > --- a/tests/kms_color.c > +++ b/tests/kms_color.c > @@ -770,7 +770,7 @@ run_ctm_tests_for_pipe(data_t *data, enum pipe p, > expected_colors[0].r = > expected_colors[1].g = > expected_colors[2].b = > - 0.5 + delta * (i - 2); > + ctm[0] + delta * (i - (iter / 2)); The name 'iter' is not a particularly great choice here. Based on that name I would expect it to be an iterator of some sort. Another thing I don't really like here is that this guy is mutating expected_colors, which was passed all the way from the top and really should be const (since the whole ctm_tests[] should be const). would be much better to have a local thing to mutate here. > if (test_pipe_ctm(data, data->primary, red_green_blue, > expected_colors, ctm)) { > success = true; > -- > 2.37.3 -- Ville Syrjälä Intel