Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Dugast <francois.dugast@intel.com>
To: <priyanka.dandamudi@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count
Date: Fri, 28 Mar 2025 09:40:55 +0100	[thread overview]
Message-ID: <Z-ZgjmTZveVN4w6b@fdugast-desk> (raw)
In-Reply-To: <20250325135817.198133-1-priyanka.dandamudi@intel.com>

On Tue, Mar 25, 2025 at 07:28:17PM +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Preemption is not happening and getting failed at the check for long
> kernel with current WMTP loop count. So, increasing the loop count.
> 
> v2: Increase loop count to 2000000 to avoid sporadic failures.
> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

LGTM but let's make sure we get CI results before merging.

Also, please see Kamil's comment regarding the commit message.

With that:
    Reviewed-by: Francois Dugast <francois.dugast@intel.com>

Francois

> ---
>  lib/intel_compute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/intel_compute.c b/lib/intel_compute.c
> index 28149db53..9dbb38709 100644
> --- a/lib/intel_compute.c
> +++ b/lib/intel_compute.c
> @@ -52,7 +52,7 @@
>   * WMTP - Walker Mid Thread Preemption
>   */
>  #define TGP_long_kernel_loop_count		10
> -#define WMTP_long_kernel_loop_count		1000000
> +#define WMTP_long_kernel_loop_count		2000000
>  
>  struct bo_dict_entry {
>  	uint64_t addr;
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2025-03-28  8:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 13:58 [PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count priyanka.dandamudi
2025-03-26  2:33 ` ✗ i915.CI.BAT: failure for lib/intel_compute.c : Increase WMTP loop count (rev2) Patchwork
2025-03-26  2:35 ` ✓ Xe.CI.BAT: success " Patchwork
2025-03-26 20:43 ` ✗ Xe.CI.Full: failure " Patchwork
2025-03-28  8:40 ` Francois Dugast [this message]
2025-03-28  9:54 ` Patchwork
2025-04-06 15:04 ` Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-03-25  5:29 [PATCH i-g-t] lib/intel_compute.c : Increase WMTP loop count priyanka.dandamudi
2025-03-25  8:51 ` Francois Dugast
2025-03-25 13:54   ` Dandamudi, Priyanka
2025-03-25 12:02 ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-ZgjmTZveVN4w6b@fdugast-desk \
    --to=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=priyanka.dandamudi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox