Re: [PATCH i-g-t v2] tests/intel/i915_hangman: Fix spin engine hang

[Andi Shyti <andi.shyti@linux.intel.com>]

Hi Mikolaj,

On Mon, Nov 25, 2024 at 10:25:50AM +0100, Mikolaj Wasiak wrote:
> Apply workaround when running background spins in hangman test.
> Disable bcs0 background engine when testing ccs0 and vice-versa.
> 
> Signed-off-by: Mikolaj Wasiak <mikolaj.wasiak@intel.com>
> ---
>  tests/intel/i915_hangman.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tests/intel/i915_hangman.c b/tests/intel/i915_hangman.c
> index a556eec53..2948cebd7 100644
> --- a/tests/intel/i915_hangman.c
> +++ b/tests/intel/i915_hangman.c
> @@ -365,6 +365,12 @@ static void chk_err(int *dst, int err, int expected)
>  #define ERR_FENCE_END  3
>  #define ERR_FENCE_STAT 4
>  
> +static bool
> +is_bcs_ccs(const struct intel_execution_engine2 *e) {

Please use Linux kernel coding style here.

Besides this declaration fits in one line within 80 characters,
no need to break it into two lines.

Otherwise the patch is fine.

Andi