From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CE88E7717F for ; Tue, 17 Dec 2024 18:08:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3355C10EA4A; Tue, 17 Dec 2024 18:08:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="hfSJrB8u"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 55BA910EA4A for ; Tue, 17 Dec 2024 18:08:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734458902; x=1765994902; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=U6Q+lHqg7O+frLRGcxGx4QxGEGMnTrETNrUNqsjJQQ4=; b=hfSJrB8uWMxRLcB+owIWioJ5eq88jWkIjoHRUcIUeBtHjRT5jBjFI4Av yYdGfeRHyU0RHkcmEitBZJ6y5uNmvbd+zKJ+avuH/bSXXuoXbQhzuY4QK sadzPXueVpea8eyOq4lCFLoroHjqViBkeCHrXBwUUh3ibnQG9tJ3ZLyDS dxI2bWNVYxo2qHmfWAoEQqrwWjYoSML71iji+mo7BiXYRfraZFqQ4uLQY A8YMzrLNZyCl+uXMdglOCFwThLT7lCiOYUczMzKEFZxa86uazOsZ5JeJQ 0QvHkSKhfnhy1iHN7VOrXt9Y0TVAfToiW32vmkLoGiK1snqwFFXbDgpUx Q==; X-CSE-ConnectionGUID: n+HNBFpPRGuRKQXDWCTnQA== X-CSE-MsgGUID: magOFYLbQouCXv33nU525g== X-IronPort-AV: E=McAfee;i="6700,10204,11282"; a="46309384" X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="46309384" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 10:08:22 -0800 X-CSE-ConnectionGUID: 2oaUUXEzSNi1BKySjpn2KA== X-CSE-MsgGUID: UacNwKTDT3yZSS3E06iWBQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,242,1728975600"; d="scan'208";a="97478548" Received: from carterle-desk.ger.corp.intel.com (HELO intel.com) ([10.245.246.58]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 10:08:20 -0800 Date: Tue, 17 Dec 2024 19:08:16 +0100 From: Andi Shyti To: Kamil Konieczny , Sebastian Brzezinka , igt-dev@lists.freedesktop.org, krzysztof.karas@intel.com Subject: Re: [PATCH] tests/intel/gem_exec_balancer: Decrease required load in `full` test Message-ID: References: <20241217162302.u52qy7ji5zlfahm5@kamilkon-desk.igk.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241217162302.u52qy7ji5zlfahm5@kamilkon-desk.igk.intel.com> X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Hi, this patch is wrongly formatted: - where is the versioning? (git format patch -v ). I think this is v4. - where is the changelog? (please after the '---' section). Please don't overlook at them next time. On Tue, Dec 17, 2024 at 05:23:02PM +0100, Kamil Konieczny wrote: > Hi Sebastian, > On 2024-12-17 at 15:06:41 +0000, Sebastian Brzezinka wrote: > > Adjust the minimal load in the `full` test. It's a minor tolerance > > issue expected 90% got 86.6%. > > > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13003 > > Remove empty line, with this Can you fix it before merging to avoid another resend? In any case: Reviewed-by: Andi Shyti Thanks, Andi > Reviewed-by: Kamil Konieczny > > > > > Signed-off-by: Sebastian Brzezinka > > --- > > tests/intel/gem_exec_balancer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/intel/gem_exec_balancer.c b/tests/intel/gem_exec_balancer.c > > index c3f0c938b..46ea19a2a 100644 > > --- a/tests/intel/gem_exec_balancer.c > > +++ b/tests/intel/gem_exec_balancer.c > > @@ -1815,7 +1815,7 @@ static void full(int i915, unsigned int flags) > > > > free(ci); > > > > - igt_assert_f(load > 0.90, > > + igt_assert_f(load > 0.85, > > "minimum load for %d x class:%d was found to be only %.1f%% busy\n", > > count, class, load*100); > > gem_quiescent_gpu(i915); > > -- > > 2.34.1 > >