Re: [PATCH i-g-t 1/4] lib/igt_sysfs: Add support for device unbinding

[Francois Dugast <francois.dugast@intel.com>]

On Fri, Feb 07, 2025 at 12:58:59PM +0530, Satyanarayana K V P wrote:
> It does not harm anything when we try to unbind a device which
> is already unbinded. We do not want to throw assertion when
> the device is already unbinded.
> 
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Cc: Michał Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Francois Dugast <francois.dugast@intel.com>

Reviewed-by: Francois Dugast <francois.dugast@intel.com>

> ---
>  lib/igt_sysfs.c | 4 ++++
>  lib/igt_sysfs.h | 1 +
>  2 files changed, 5 insertions(+)
> 
> diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
> index 2e4c2ee63..3fffaf96b 100644
> --- a/lib/igt_sysfs.c
> +++ b/lib/igt_sysfs.c
> @@ -1509,6 +1509,10 @@ int xe_sysfs_driver_do(int xe_device, char pci_slot[], enum xe_sysfs_driver_acti
>  		igt_assert(igt_sysfs_set(sysfs, "unbind", pci_slot));
>  		close(sysfs);
>  		break;
> +	case XE_SYSFS_DRIVER_TRY_UNBIND:
> +		igt_sysfs_set(sysfs, "unbind", pci_slot);
> +		close(sysfs);
> +		break;
>  	case XE_SYSFS_DRIVER_REBIND:
>  		igt_assert(igt_sysfs_set(sysfs, "unbind", pci_slot));
>  
> diff --git a/lib/igt_sysfs.h b/lib/igt_sysfs.h
> index 86345f3d1..cc4971e70 100644
> --- a/lib/igt_sysfs.h
> +++ b/lib/igt_sysfs.h
> @@ -187,6 +187,7 @@ enum xe_sysfs_driver_action {
>  	XE_SYSFS_DRIVER_BIND,
>  	XE_SYSFS_DRIVER_TRY_BIND,
>  	XE_SYSFS_DRIVER_UNBIND,
> +	XE_SYSFS_DRIVER_TRY_UNBIND,
>  	XE_SYSFS_DRIVER_REBIND,
>  };
>  
> -- 
> 2.35.3
>