Re: [PATCH i-g-t v1] Add support for runtime pm for xe driver

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Mar 06, 2025 at 11:45:15AM -0500, Gupta, Anshuman wrote:
> 
> offlist
> > -----Original Message-----
> > From: Vivi, Rodrigo <rodrigo.vivi@intel.com>
> > Sent: Thursday, March 6, 2025 9:41 PM
> > To: Purkait, Soham <soham.purkait@intel.com>
> > Cc: igt-dev@lists.freedesktop.org; Tauro, Riana <riana.tauro@intel.com>;
> > Belgaumkar, Vinay <vinay.belgaumkar@intel.com>; Gupta, Anshuman
> > <anshuman.gupta@intel.com>; De Marchi, Lucas <lucas.demarchi@intel.com>
> > Subject: Re: [PATCH i-g-t v1] Add support for runtime pm for xe driver
> > 
> > On Thu, Mar 06, 2025 at 04:57:54PM +0530, Soham Purkait wrote:
> > > Add support for runtime power management for Xe driver.
> > 
> > Why?
> > 
> > We already have that covered with xe_pm d3hot and d3cold tests.
> We need to this tool for e2e validation to keep the card in d3cold for longer duration and verify the Package G state counters by Python SV. It is useful tool. 

Fair enough. If there are cases that we are not covering with the xe_pm,
let's do it. Just please let's explain that in the commit message.

> 
> Thanks,
> Anshuman.
> 
> > 
> > >
> > > ---
> > >  tools/intel_pm_rpm.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/intel_pm_rpm.c b/tools/intel_pm_rpm.c index
> > > 08c25ca8a..945247d2e 100644
> > > --- a/tools/intel_pm_rpm.c
> > > +++ b/tools/intel_pm_rpm.c
> > > @@ -151,7 +151,7 @@ int main(int argc, char *argv[])
> > >  			goto exit;
> > >  		}
> > >  	} else {
> > > -		if (!igt_device_find_first_i915_discrete_card(&card)) {
> > > +		if (!igt_device_find_first_i915_discrete_card(&card) &&
> > > +!igt_device_find_first_xe_discrete_card(&card)) {
> > >  			igt_warn("No discrete gpu found\n");
> > >  			ret = EXIT_FAILURE;
> > >  			goto exit;
> > > --
> > > 2.34.1
> > >