Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
To: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <ashutosh.dixit@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/xe_oa: Don't limit oa-formats to render engine
Date: Fri, 7 Mar 2025 11:48:08 -0800	[thread overview]
Message-ID: <Z8tNeMOPo7GEiXat@soc-5CG1426VCC.clients.intel.com> (raw)
In-Reply-To: <20250305175557.2245712-1-sai.teja.pottumuttu@intel.com>

On Wed, Mar 05, 2025 at 11:25:57PM +0530, Sai Teja Pottumuttu wrote:
>oa-formats test need not be limited to render engine only. Extend
>it to use any engine using __for_one_hwe_in_oag macro instead.
>
>Signed-off-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>

LGTM,

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Thanks,
Umesh
>---
> tests/intel/xe_oa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
>index a72def0fe..81f2a7e0c 100644
>--- a/tests/intel/xe_oa.c
>+++ b/tests/intel/xe_oa.c
>@@ -4717,7 +4717,7 @@ igt_main
> 		test_missing_sample_flags();
>
> 	igt_subtest_with_dynamic("oa-formats")
>-		__for_one_render_engine(hwe)
>+		__for_one_hwe_in_oag(hwe)
> 			test_oa_formats(hwe);
>
> 	igt_subtest("invalid-oa-exponent")
>-- 
>2.34.1
>

      parent reply	other threads:[~2025-03-07 19:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 17:55 [PATCH i-g-t] tests/intel/xe_oa: Don't limit oa-formats to render engine Sai Teja Pottumuttu
2025-03-06  7:00 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-03-06  7:21 ` ✓ i915.CI.BAT: " Patchwork
2025-03-06  9:34 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-06 14:51 ` ✗ Xe.CI.Full: " Patchwork
2025-03-07 19:48 ` Umesh Nerlige Ramappa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8tNeMOPo7GEiXat@soc-5CG1426VCC.clients.intel.com \
    --to=umesh.nerlige.ramappa@intel.com \
    --cc=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=sai.teja.pottumuttu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox