From: Petri Latvala <adrinael@adrinael.net>
To: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] intel-ci: update blacklists to work with the Xe driver
Date: Sat, 25 Mar 2023 05:08:56 +0200 [thread overview]
Message-ID: <ZB5lyIqBKibgC5/C@adrinael.net> (raw)
In-Reply-To: <20230323151537.75d5efe3@maurocar-mobl2>
On Thu, Mar 23, 2023 at 03:15:37PM +0100, Mauro Carvalho Chehab wrote:
> On Thu, 23 Mar 2023 15:18:18 +0200
> Petri Latvala <adrinael@adrinael.net> wrote:
>
> > On Wed, Mar 22, 2023 at 08:29:47AM +0100, Mauro Carvalho Chehab wrote:
> > > From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > >
> > > It doesn't make sense to run i915 tests with Xe driver and
> > > vice-versa. Update testlists to make it clear.
> > >
> > > In order to avoid disrupts at exiting intel-ci tests, keep a
> > > symlink:
> > > i915-blacklist.txt -> blacklist.txt
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > > ---
> > > tests/intel-ci/blacklist.txt | 130 +----------------------------
> > > tests/intel-ci/i915-blacklist.txt | 133 ++++++++++++++++++++++++++++++
> > > tests/intel-ci/xe-blacklist.txt | 21 +++++
> > > 3 files changed, 155 insertions(+), 129 deletions(-)
> > > mode change 100644 => 120000 tests/intel-ci/blacklist.txt
> > > create mode 100644 tests/intel-ci/i915-blacklist.txt
> > > create mode 100644 tests/intel-ci/xe-blacklist.txt
> >
> > Since a rename is happening anyway, let's rename to inclusive language
> > at the same time? i915-blocklist.txt + xe-blocklist.txt
>
> Currently, we have 2 such files:
>
> tests/intel-ci/blacklist-pre-merge.txt
> tests/intel-ci/blacklist.txt
>
> IMO, a rename from <blacklist> to whatever now-preferred namespace
> should touch both.
>
> Yet, renames like that will break CI, so symlinks to the old names
> are required.
>
> If you're ok with that, I can prepare an upcoming series with
> the renames, including renaming from "*blacklist*" to
> "*blocklist*" namespace and adding the needed symlinks to preserve
> CI from regressions.
Yeah, that sounds good. Get an ack from someone in the CI team as well
for it, just so they know in case something really weird breaks deeper
in the CI machinery.
--
Petri Latvala
prev parent reply other threads:[~2023-03-25 3:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 7:29 [igt-dev] [PATCH i-g-t] intel-ci: update blacklists to work with the Xe driver Mauro Carvalho Chehab
2023-03-22 8:27 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-03-22 12:15 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-03-23 13:18 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2023-03-23 14:15 ` Mauro Carvalho Chehab
2023-03-25 3:08 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB5lyIqBKibgC5/C@adrinael.net \
--to=adrinael@adrinael.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=mauro.chehab@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox