Re: [igt-dev] [i-g-t V2 2/3] tests/i915/kms_ccs: Cleanup to use linear modifier

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Mon, Mar 13, 2023 at 08:44:05PM +0530, Bhanuprakash Modem wrote:
> Use either compressed or linear modifier to test. Due to the
> lack of available bandwidth, we cannot fit two CCS planes into
> the available FIFO configurations.
> 
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  tests/i915/kms_ccs.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/tests/i915/kms_ccs.c b/tests/i915/kms_ccs.c
> index 9be3fa252..18d48fb80 100644
> --- a/tests/i915/kms_ccs.c
> +++ b/tests/i915/kms_ccs.c
> @@ -393,10 +393,8 @@ static void generate_fb(data_t *data, struct igt_fb *fb,
>  	 */
>  	if (fb_flags & FB_COMPRESSED)
>  		modifier = data->ccs_modifier;
> -	else if (!(fb_flags & FB_HAS_PLANE))
> -		modifier = DRM_FORMAT_MOD_LINEAR;
>  	else
> -		modifier = 0;
> +		modifier = DRM_FORMAT_MOD_LINEAR;

Isn't this whole change a nop? If so why does the commit message
seem to indicate some kind of functional change?

>  
>  	create_fb_prepare_add(data->drm_fd, width, height,
>  			      data->format, modifier,
> -- 
> 2.39.1

-- 
Ville Syrjälä
Intel