From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jasber Chen <yipeng.chen@amd.com>
Cc: igt-dev@lists.freedesktop.org,
Jasber Chen <yipeng.chen@amd.corp-partner.google.com>
Subject: Re: [igt-dev] [PATCH] correct validating config on enconder mask. Then mode setting can be run through with multiple displays.
Date: Tue, 21 Mar 2023 14:45:43 +0200 [thread overview]
Message-ID: <ZBmm90YOzarKx7tO@intel.com> (raw)
In-Reply-To: <20230321024826.1722421-1-yipeng.chen@amd.com>
On Tue, Mar 21, 2023 at 10:48:26AM +0800, Jasber Chen wrote:
> From: Jasber Chen <yipeng.chen@amd.corp-partner.google.com>
>
> Signed-off-by: yipeng.chen@amd.com
> ---
> tests/kms_setmode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index bfa10891..4e59f2aa 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -331,7 +331,7 @@ static void setup_crtcs(const struct test_config *tconf,
>
> encoder_mask |= 1 << get_encoder_idx(resources,
> encoder);
> - config_valid &= !(encoder_mask &
> + config_valid &= !!(encoder_mask &
> ~encoder->possible_clones);
The code looks correct the way it is.
>
> drmModeFreeEncoder(encoder);
> --
> 2.25.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2023-03-21 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 2:48 [igt-dev] [PATCH] correct validating config on enconder mask. Then mode setting can be run through with multiple displays Jasber Chen
2023-03-21 8:53 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-03-21 12:45 ` Ville Syrjälä [this message]
2023-03-21 13:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBmm90YOzarKx7tO@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=yipeng.chen@amd.com \
--cc=yipeng.chen@amd.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox