From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: multipart/alternative; boundary="===============5415074175357377727==" MIME-Version: 1.0 From: Patchwork To: "Vinay Belgaumkar" Date: Sat, 25 Mar 2023 01:06:25 -0000 Message-ID: <167970638565.22914.17273420023011402522@emeril.freedesktop.org> References: <20230325003442.1767568-1-vinay.belgaumkar@intel.com> In-Reply-To: <20230325003442.1767568-1-vinay.belgaumkar@intel.com> Subject: [igt-dev] =?utf-8?b?4pyTIEZpLkNJLkJBVDogc3VjY2VzcyBmb3IgdGVzdHMv?= =?utf-8?q?xe=5Fguc=5Fpc=3A_Restore_max_freq_first?= List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: igt-dev@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: --===============5415074175357377727== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit == Series Details == Series: tests/xe_guc_pc: Restore max freq first URL : https://patchwork.freedesktop.org/series/115628/ State : success == Summary == CI Bug Log - changes from CI_DRM_12914 -> IGTPW_8682 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html Participating hosts (38 -> 36) ------------------------------ Missing (2): fi-kbl-soraka fi-snb-2520m Known issues ------------ Here are the changes found in IGTPW_8682 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_selftest@live@reset: - bat-rpls-2: [PASS][1] -> [ABORT][2] ([i915#4983] / [i915#7913]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/bat-rpls-2/igt@i915_selftest@live@reset.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/bat-rpls-2/igt@i915_selftest@live@reset.html - bat-rpls-1: [PASS][3] -> [ABORT][4] ([i915#4983]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/bat-rpls-1/igt@i915_selftest@live@reset.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/bat-rpls-1/igt@i915_selftest@live@reset.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0@smem: - bat-dg1-5: [FAIL][5] ([fdo#103375]) -> [PASS][6] +7 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/bat-dg1-5/igt@gem_exec_suspend@basic-s0@smem.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/bat-dg1-5/igt@gem_exec_suspend@basic-s0@smem.html [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7218 -> IGTPW_8682 CI-20190529: 20190529 CI_DRM_12914: 6e5f96153989e454041848f66a5227be9bd0bbc3 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_8682: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html IGT_7218: 8036123f781059c54a31240756794b17bd3d15dc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Testlist changes ---------------- -igt@i915_guc_pc@freq-basic-api -igt@i915_guc_pc@freq-reset == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html --===============5415074175357377727== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Project List - Patchwork Patch Details

Series:	tests/xe_guc_pc: Restore max freq first
URL:	https://patchwork.freedesktop.org/series/115628/
State:	success
Details:	https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html

CI Bug Log - changes from CI_DRM_12914 -> IGTPW_8682

Summary

SUCCESS

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html

Participating hosts (38 -> 36)

Missing (2): fi-kbl-soraka fi-snb-2520m

Known issues

Here are the changes found in IGTPW_8682 that come from known issues:

IGT changes

Issues hit

igt@i915_selftest@live@reset:
- bat-rpls-2: PASS -> ABORT (i915#4983 / i915#7913)
- bat-rpls-1: PASS -> ABORT (i915#4983)

Possible fixes

igt@gem_exec_suspend@basic-s0@smem:
- bat-dg1-5: FAIL (fdo#103375) -> PASS +7 similar issues

Build changes

CI: CI-20190529 -> None
IGT: IGT_7218 -> IGTPW_8682

CI-20190529: 20190529
CI_DRM_12914: 6e5f96153989e454041848f66a5227be9bd0bbc3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8682: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html
IGT_7218: 8036123f781059c54a31240756794b17bd3d15dc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes

-igt@i915_guc_pc@freq-basic-api
-igt@i915_guc_pc@freq-reset

--===============5415074175357377727==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Vinay Belgaumkar To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org Date: Fri, 24 Mar 2023 17:34:42 -0700 Message-Id: <20230325003442.1767568-1-vinay.belgaumkar@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t] tests/xe_guc_pc: Restore max freq first List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: When min/max are both at RPn, restoring min back to 300 will not work. Max needs to be increased first. Also, add igt_assert() here, which would have caught the issue. Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- tests/xe/xe_guc_pc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/xe/xe_guc_pc.c b/tests/xe/xe_guc_pc.c index 60c93288..43bf6f48 100644 --- a/tests/xe/xe_guc_pc.c +++ b/tests/xe/xe_guc_pc.c @@ -489,8 +489,8 @@ igt_main igt_fixture { xe_for_each_gt(fd, gt) { - set_freq(sysfs, gt, "min", stash_min); - set_freq(sysfs, gt, "max", stash_max); + igt_assert(set_freq(sysfs, gt, "max", stash_max) > 0); + igt_assert(set_freq(sysfs, gt, "min", stash_min) > 0); } close(sysfs); xe_device_put(fd); -- 2.38.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: multipart/alternative; boundary="===============1218367995718596328==" MIME-Version: 1.0 From: Patchwork To: "Vinay Belgaumkar" Date: Sat, 25 Mar 2023 09:06:22 -0000 Message-ID: <167973518252.22914.17271977028983588170@emeril.freedesktop.org> References: <20230325003442.1767568-1-vinay.belgaumkar@intel.com> In-Reply-To: <20230325003442.1767568-1-vinay.belgaumkar@intel.com> Subject: [igt-dev] =?utf-8?b?4pyTIEZpLkNJLklHVDogc3VjY2VzcyBmb3IgdGVzdHMv?= =?utf-8?q?xe=5Fguc=5Fpc=3A_Restore_max_freq_first?= List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: igt-dev@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: --===============1218367995718596328== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit == Series Details == Series: tests/xe_guc_pc: Restore max freq first URL : https://patchwork.freedesktop.org/series/115628/ State : success == Summary == CI Bug Log - changes from CI_DRM_12914_full -> IGTPW_8682_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html Participating hosts (7 -> 7) ------------------------------ No changes in participating hosts Known issues ------------ Here are the changes found in IGTPW_8682_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-apl: [PASS][1] -> [FAIL][2] ([i915#2842]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_lmem_swapping@verify-random-ccs: - shard-glk: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-glk9/igt@gem_lmem_swapping@verify-random-ccs.html * igt@gem_pwrite@basic-exhaustion: - shard-glk: NOTRUN -> [WARN][4] ([i915#2658]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-glk9/igt@gem_pwrite@basic-exhaustion.html * igt@kms_atomic_transition@plane-all-transition-nonblocking: - shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271]) +7 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-snb5/igt@kms_atomic_transition@plane-all-transition-nonblocking.html * igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc: - shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#3886]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-glk4/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html * igt@kms_cursor_crc@cursor-random-max-size: - shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271]) +46 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-glk3/igt@kms_cursor_crc@cursor-random-max-size.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-glk: [PASS][8] -> [FAIL][9] ([i915#2346]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-snb: [PASS][10] -> [DMESG-WARN][11] ([i915#5090]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-snb5/igt@kms_fbcon_fbt@fbc-suspend.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-snb5/igt@kms_fbcon_fbt@fbc-suspend.html #### Possible fixes #### * igt@drm_read@short-buffer-block: - {shard-rkl}: [SKIP][12] ([i915#4098]) -> [PASS][13] +1 similar issue [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-5/igt@drm_read@short-buffer-block.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-6/igt@drm_read@short-buffer-block.html * igt@fbdev@write: - {shard-rkl}: [SKIP][14] ([i915#2582]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-5/igt@fbdev@write.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-6/igt@fbdev@write.html * {igt@gem_barrier_race@remote-request@rcs0}: - {shard-rkl}: [ABORT][16] ([i915#8211]) -> [PASS][17] [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-3/igt@gem_barrier_race@remote-request@rcs0.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-3/igt@gem_barrier_race@remote-request@rcs0.html * igt@gem_eio@in-flight-suspend: - {shard-rkl}: [FAIL][18] ([fdo#103375]) -> [PASS][19] +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-4/igt@gem_eio@in-flight-suspend.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-1/igt@gem_eio@in-flight-suspend.html * igt@gem_exec_balancer@fairslice: - {shard-rkl}: [SKIP][20] ([i915#6259]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-5/igt@gem_exec_balancer@fairslice.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-4/igt@gem_exec_balancer@fairslice.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-glk: [FAIL][22] ([i915#2842]) -> [PASS][23] [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-glk9/igt@gem_exec_fair@basic-pace@rcs0.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-glk4/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_reloc@basic-gtt-wc-noreloc: - {shard-rkl}: [SKIP][24] ([i915#3281]) -> [PASS][25] +5 similar issues [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-3/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html * igt@gem_exec_whisper@basic-fds-priority-all: - {shard-tglu}: [INCOMPLETE][26] ([i915#6755]) -> [PASS][27] [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-tglu-5/igt@gem_exec_whisper@basic-fds-priority-all.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-tglu-7/igt@gem_exec_whisper@basic-fds-priority-all.html * igt@gem_mmap_gtt@coherency: - {shard-rkl}: [SKIP][28] ([fdo#111656]) -> [PASS][29] [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-1/igt@gem_mmap_gtt@coherency.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-5/igt@gem_mmap_gtt@coherency.html * igt@gem_partial_pwrite_pread@reads-uncached: - {shard-rkl}: [SKIP][30] ([i915#3282]) -> [PASS][31] +1 similar issue [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-3/igt@gem_partial_pwrite_pread@reads-uncached.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-5/igt@gem_partial_pwrite_pread@reads-uncached.html * igt@gem_workarounds@suspend-resume: - {shard-rkl}: [ABORT][32] ([i915#5122]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-4/igt@gem_workarounds@suspend-resume.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-4/igt@gem_workarounds@suspend-resume.html * igt@gen9_exec_parse@cmd-crossing-page: - {shard-rkl}: [SKIP][34] ([i915#2527]) -> [PASS][35] [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-4/igt@gen9_exec_parse@cmd-crossing-page.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-5/igt@gen9_exec_parse@cmd-crossing-page.html * igt@i915_module_load@reload: - shard-snb: [ABORT][36] ([i915#4528]) -> [PASS][37] [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-snb2/igt@i915_module_load@reload.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-snb2/igt@i915_module_load@reload.html * igt@i915_pm_dc@dc5-psr: - {shard-rkl}: [SKIP][38] ([i915#658]) -> [PASS][39] [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-4/igt@i915_pm_dc@dc5-psr.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-6/igt@i915_pm_dc@dc5-psr.html * igt@i915_pm_rpm@dpms-mode-unset-lpsp: - {shard-tglu}: [SKIP][40] ([i915#1397]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-tglu-9/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-tglu-1/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html * igt@i915_pm_rpm@drm-resources-equal: - {shard-rkl}: [SKIP][42] ([fdo#109308]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-5/igt@i915_pm_rpm@drm-resources-equal.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-6/igt@i915_pm_rpm@drm-resources-equal.html * igt@i915_pm_rpm@modeset-lpsp: - {shard-dg1}: [SKIP][44] ([i915#1397]) -> [PASS][45] [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-dg1-16/igt@i915_pm_rpm@modeset-lpsp.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-dg1-14/igt@i915_pm_rpm@modeset-lpsp.html * igt@i915_pm_rpm@modeset-lpsp-stress-no-wait: - {shard-rkl}: [SKIP][46] ([i915#1397]) -> [PASS][47] [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-4/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html * igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs: - {shard-tglu}: [SKIP][48] ([i915#1845] / [i915#7651]) -> [PASS][49] +23 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-tglu-9/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-tglu-3/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-apl: [FAIL][50] ([i915#2346]) -> [PASS][51] [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_cursor_legacy@forked-move@pipe-b: - {shard-rkl}: [INCOMPLETE][52] ([i915#8011]) -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-6/igt@kms_cursor_legacy@forked-move@pipe-b.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-3/igt@kms_cursor_legacy@forked-move@pipe-b.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1: - shard-glk: [FAIL][54] ([i915#79]) -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt: - {shard-tglu}: [SKIP][56] ([i915#1849]) -> [PASS][57] +10 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-tglu-2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwrite: - {shard-rkl}: [SKIP][58] ([i915#1849] / [i915#4098]) -> [PASS][59] +12 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-4/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwrite.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwrite.html * {igt@kms_plane@invalid-pixel-format-settings}: - {shard-tglu}: [SKIP][60] ([i915#8152]) -> [PASS][61] [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-tglu-9/igt@kms_plane@invalid-pixel-format-settings.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-tglu-3/igt@kms_plane@invalid-pixel-format-settings.html * igt@kms_psr@primary_render: - {shard-rkl}: [SKIP][62] ([i915#1072]) -> [PASS][63] +1 similar issue [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-5/igt@kms_psr@primary_render.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-6/igt@kms_psr@primary_render.html * igt@kms_universal_plane@universal-plane-pipe-c-sanity: - {shard-tglu}: [SKIP][64] ([i915#1845]) -> [PASS][65] +16 similar issues [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-tglu-9/igt@kms_universal_plane@universal-plane-pipe-c-sanity.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-tglu-2/igt@kms_universal_plane@universal-plane-pipe-c-sanity.html * igt@kms_vblank@pipe-b-query-forked: - {shard-rkl}: [SKIP][66] ([i915#1845] / [i915#4098]) -> [PASS][67] +12 similar issues [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-4/igt@kms_vblank@pipe-b-query-forked.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-6/igt@kms_vblank@pipe-b-query-forked.html * {igt@perf@gen12-group-exclusive-stream-sample-oa}: - {shard-rkl}: [SKIP][68] -> [PASS][69] [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12914/shard-rkl-5/igt@perf@gen12-group-exclusive-stream-sample-oa.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/shard-rkl-4/igt@perf@gen12-group-exclusive-stream-sample-oa.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313 [fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755 [i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850 [i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434 [i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469 [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966 [i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4778]: https://gitlab.freedesktop.org/drm/intel/issues/4778 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880 [i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881 [i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958 [i915#5090]: https://gitlab.freedesktop.org/drm/intel/issues/5090 [i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115 [i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122 [i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608 [i915#5775]: https://gitlab.freedesktop.org/drm/intel/issues/5775 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259 [i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268 [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6755]: https://gitlab.freedesktop.org/drm/intel/issues/6755 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953 [i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037 [i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651 [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949 [i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957 [i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011 [i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152 [i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154 [i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211 [i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7218 -> IGTPW_8682 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_12914: 6e5f96153989e454041848f66a5227be9bd0bbc3 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_8682: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html IGT_7218: 8036123f781059c54a31240756794b17bd3d15dc @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html --===============1218367995718596328== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Project List - Patchwork Patch Details

Series:	tests/xe_guc_pc: Restore max freq first
URL:	https://patchwork.freedesktop.org/series/115628/
State:	success
Details:	https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html

CI Bug Log - changes from CI_DRM_12914_full -> IGTPW_8682_full

Summary

SUCCESS

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8682/index.html

Participating hosts (7 -> 7)

No changes in participating hosts

Known issues

Here are the changes found in IGTPW_8682_full that come from known issues:

IGT changes

Issues hit

igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: PASS -> FAIL (i915#2842)
igt@gem_lmem_swapping@verify-random-ccs:
- shard-glk: NOTRUN -> SKIP (fdo#109271 / i915#4613) +1 similar issue
igt@gem_pwrite@basic-exhaustion:
- shard-glk: NOTRUN -> WARN (i915#2658)
igt@kms_atomic_transition@plane-all-transition-nonblocking:
- shard-snb: NOTRUN -> SKIP (fdo#109271) +7 similar issues
igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> SKIP (fdo#109271 / i915#3886) +1 similar issue
igt@kms_cursor_crc@cursor-random-max-size:
- shard-glk: NOTRUN -> SKIP (fdo#109271) +46 similar issues
igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: PASS -> FAIL (i915#2346)
igt@kms_fbcon_fbt@fbc-suspend:
- shard-snb: PASS -> DMESG-WARN (i915#5090)

Possible fixes

igt@drm_read@short-buffer-block:
- {shard-rkl}: SKIP (i915#4098) -> PASS +1 similar issue
igt@fbdev@write:
- {shard-rkl}: SKIP (i915#2582) -> PASS
{igt@gem_barrier_race@remote-request@rcs0}:
- {shard-rkl}: ABORT (i915#8211) -> PASS
igt@gem_eio@in-flight-suspend:
- {shard-rkl}: FAIL (fdo#103375) -> PASS +1 similar issue
igt@gem_exec_balancer@fairslice:
- {shard-rkl}: SKIP (i915#6259) -> PASS
igt@gem_exec_fair@basic-pace@rcs0:
- shard-glk: FAIL (i915#2842) -> PASS
igt@gem_exec_reloc@basic-gtt-wc-noreloc:
- {shard-rkl}: SKIP (i915#3281) -> PASS +5 similar issues
igt@gem_exec_whisper@basic-fds-priority-all:
- {shard-tglu}: INCOMPLETE (i915#6755) -> PASS
igt@gem_mmap_gtt@coherency:
- {shard-rkl}: SKIP (fdo#111656) -> PASS
igt@gem_partial_pwrite_pread@reads-uncached:
- {shard-rkl}: SKIP (i915#3282) -> PASS +1 similar issue
igt@gem_workarounds@suspend-resume:
- {shard-rkl}: ABORT (i915#5122) -> PASS
igt@gen9_exec_parse@cmd-crossing-page:
- {shard-rkl}: SKIP (i915#2527) -> PASS
igt@i915_module_load@reload:
- shard-snb: ABORT (i915#4528) -> PASS
igt@i915_pm_dc@dc5-psr:
- {shard-rkl}: SKIP (i915#658) -> PASS
igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-tglu}: SKIP (i915#1397) -> PASS
igt@i915_pm_rpm@drm-resources-equal:
- {shard-rkl}: SKIP (fdo#109308) -> PASS
igt@i915_pm_rpm@modeset-lpsp:
- {shard-dg1}: SKIP (i915#1397) -> PASS
igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: SKIP (i915#1397) -> PASS
igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs:
- {shard-tglu}: SKIP (i915#1845 / i915#7651) -> PASS +23 similar issues
igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: FAIL (i915#2346) -> PASS
igt@kms_cursor_legacy@forked-move@pipe-b:
- {shard-rkl}: INCOMPLETE (i915#8011) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: FAIL (i915#79) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- {shard-tglu}: SKIP (i915#1849) -> PASS +10 similar issues
igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-pwrite:
- {shard-rkl}: SKIP (i915#1849 / i915#4098) -> PASS +12 similar issues
{igt@kms_plane@invalid-pixel-format-settings}:
- {shard-tglu}: SKIP (i915#8152) -> PASS
igt@kms_psr@primary_render:
- {shard-rkl}: SKIP (i915#1072) -> PASS +1 similar issue
igt@kms_universal_plane@universal-plane-pipe-c-sanity:
- {shard-tglu}: SKIP (i915#1845) -> PASS +16 similar issues
igt@kms_vblank@pipe-b-query-forked:
- {shard-rkl}: SKIP (i915#1845 / i915#4098) -> PASS +12 similar issues
{igt@perf@gen12-group-exclusive-stream-sample-oa}:
- {shard-rkl}: SKIP -> PASS

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes

CI: CI-20190529 -> None
IGT: IGT_7218 -> IGTPW_8682
Piglit: piglit_4509 -> None

--===============1218367995718596328==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 26 Mar 2023 06:51:03 -0400 From: Rodrigo Vivi To: Vinay Belgaumkar Message-ID: References: <20230325003442.1767568-1-vinay.belgaumkar@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230325003442.1767568-1-vinay.belgaumkar@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tests/xe_guc_pc: Restore max freq first List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, Mar 24, 2023 at 05:34:42PM -0700, Vinay Belgaumkar wrote: > When min/max are both at RPn, restoring min back to 300 > will not work. Max needs to be increased first. why max needs to come first in this case? we should probably at least document so we don't forget it again... > Also, add > igt_assert() here, which would have caught the issue. I was going to ask if we should really add asserts inside the fixture or maybe using igt_require instead, but then I noticed more cases doing the assert... > > Cc: Rodrigo Vivi > Signed-off-by: Vinay Belgaumkar > --- > tests/xe/xe_guc_pc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/xe/xe_guc_pc.c b/tests/xe/xe_guc_pc.c > index 60c93288..43bf6f48 100644 > --- a/tests/xe/xe_guc_pc.c > +++ b/tests/xe/xe_guc_pc.c > @@ -489,8 +489,8 @@ igt_main > > igt_fixture { > xe_for_each_gt(fd, gt) { > - set_freq(sysfs, gt, "min", stash_min); > - set_freq(sysfs, gt, "max", stash_max); > + igt_assert(set_freq(sysfs, gt, "max", stash_max) > 0); > + igt_assert(set_freq(sysfs, gt, "min", stash_min) > 0); > } > close(sysfs); > xe_device_put(fd); > -- > 2.38.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <14d722ff-f577-297d-db95-4d6f95d39336@intel.com> Date: Mon, 27 Mar 2023 16:04:50 -0700 Content-Language: en-US To: Rodrigo Vivi References: <20230325003442.1767568-1-vinay.belgaumkar@intel.com> From: "Belgaumkar, Vinay" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] tests/xe_guc_pc: Restore max freq first List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 3/26/2023 3:51 AM, Rodrigo Vivi wrote: > On Fri, Mar 24, 2023 at 05:34:42PM -0700, Vinay Belgaumkar wrote: >> When min/max are both at RPn, restoring min back to 300 >> will not work. Max needs to be increased first. > why max needs to come first in this case? we should probably at > least document so we don't forget it again... I was assuming we use soft limits like in i915, but looks like we don't. So, this is not an issue. > >> Also, add >> igt_assert() here, which would have caught the issue. > I was going to ask if we should really add asserts inside the fixture > or maybe using igt_require instead, but then I noticed more cases > doing the assert... Do we still need to add the assert in this case? Thanks, Vinay. > >> Cc: Rodrigo Vivi >> Signed-off-by: Vinay Belgaumkar >> --- >> tests/xe/xe_guc_pc.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tests/xe/xe_guc_pc.c b/tests/xe/xe_guc_pc.c >> index 60c93288..43bf6f48 100644 >> --- a/tests/xe/xe_guc_pc.c >> +++ b/tests/xe/xe_guc_pc.c >> @@ -489,8 +489,8 @@ igt_main >> >> igt_fixture { >> xe_for_each_gt(fd, gt) { >> - set_freq(sysfs, gt, "min", stash_min); >> - set_freq(sysfs, gt, "max", stash_max); >> + igt_assert(set_freq(sysfs, gt, "max", stash_max) > 0); >> + igt_assert(set_freq(sysfs, gt, "min", stash_min) > 0); >> } >> close(sysfs); >> xe_device_put(fd); >> -- >> 2.38.1 >>