From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2D5710E21D for ; Tue, 4 Apr 2023 22:12:20 +0000 (UTC) Date: Tue, 4 Apr 2023 15:11:43 -0700 From: Niranjana Vishwanathapura To: Matthew Auld Message-ID: References: <20230404120042.146323-1-matthew.auld@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230404120042.146323-1-matthew.auld@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/xe_query: fix vram_memory() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Tue, Apr 04, 2023 at 01:00:41PM +0100, Matthew Auld wrote: >It looks like this is meant to return VRAM if supported. If we call this >on igpu it should return zero. There is at least one user relying on >this in xe_mmap@vram, where we want to skip if the mask here is zero. > Below patch was sent before, but never got merged. https://patchwork.freedesktop.org/series/115409/ There are some minor differences. Can you pick those changes? Also, cover letter seems to be missing for this series. Or, we can simple merge them into a single patch as they are related? Niranjana >Reported-by: Gwan-gyeong Mun >Signed-off-by: Matthew Auld >Cc: Zbigniew Kempczyński >Cc: Matthew Brost >--- > lib/xe/xe_query.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c >index 24a258a5e..253164d6b 100644 >--- a/lib/xe/xe_query.c >+++ b/lib/xe/xe_query.c >@@ -380,7 +380,7 @@ uint64_t vram_memory(int fd, int gt) > igt_assert(xe_dev); > igt_assert(gt >= 0 && gt < xe_dev->number_gt); > >- return native_region_for_gt(xe_dev->gts, gt); >+ return native_region_for_gt(xe_dev->gts, gt) & (~0x1); > } > > /** >-- >2.39.2 >