From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id D996188C3D for ; Mon, 24 Apr 2023 18:18:27 +0000 (UTC) Date: Mon, 24 Apr 2023 21:18:23 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: =?iso-8859-1?Q?Ma=EDra?= Canal Message-ID: References: <20230424172407.451109-1-mcanal@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230424172407.451109-1-mcanal@igalia.com> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: require GAMMA_LUT property for legacy_lut tests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Mon, Apr 24, 2023 at 02:24:07PM -0300, Maíra Canal wrote: > Currently, the tests pixel-format and pixel-format-source-clamping > fail for drivers that doesn't have the IGT_CRTC_GAMMA_LUT property, > as they are not able to complete drmModeCrtcSetGamma() successfully. > Therefore, require the IGT_CRTC_GAMMA_LUT property before running the > tests. This way the tests can skip gracefully for drivers without > this property. > > Signed-off-by: Maíra Canal > --- > tests/kms_plane.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/kms_plane.c b/tests/kms_plane.c > index 62aee9ad..a0e4e80f 100644 > --- a/tests/kms_plane.c > +++ b/tests/kms_plane.c > @@ -451,6 +451,8 @@ static void set_legacy_lut(data_t *data, enum pipe pipe, > uint16_t *lut; > int i, lut_size; > > + igt_require(igt_pipe_obj_has_prop(pipe_obj, IGT_CRTC_GAMMA_LUT)); Skipping all pixel format tests isn't a great plan. Also, you want to check crtc->gamma_size intead. That is what indicates support for the legacy gamma. > + > crtc = drmModeGetCrtc(data->drm_fd, pipe_obj->crtc_id); > lut_size = crtc->gamma_size; > drmModeFreeCrtc(crtc); > @@ -474,6 +476,8 @@ static bool set_c8_legacy_lut(data_t *data, enum pipe pipe, > uint16_t *r, *g, *b; > int i, lut_size; > > + igt_require(igt_pipe_obj_has_prop(pipe_obj, IGT_CRTC_GAMMA_LUT)); > + > crtc = drmModeGetCrtc(data->drm_fd, pipe_obj->crtc_id); > lut_size = crtc->gamma_size; > drmModeFreeCrtc(crtc); > -- > 2.40.0 -- Ville Syrjälä Intel