From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6D5A10E138 for ; Wed, 12 Jul 2023 08:18:58 +0000 (UTC) Date: Wed, 12 Jul 2023 10:18:47 +0200 From: Andi Shyti To: Tvrtko Ursulin Message-ID: References: <20230606175226.502703-1-andi.shyti@linux.intel.com> <20230606175226.502703-2-andi.shyti@linux.intel.com> <20230607085737.tgauj4s2pvbjx7rg@kamilkon-desk1> <500f3993-dc82-bc64-31b1-df7390164251@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <500f3993-dc82-bc64-31b1-df7390164251@linux.intel.com> Subject: Re: [igt-dev] [PATCH v3 1/1] test/gem_create: limit set_pat only to Meteor Lake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: IGT dev , Tvrtko Ursulin , Fei Yang Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi, On Wed, Jul 12, 2023 at 09:09:55AM +0100, Tvrtko Ursulin wrote: > > On 07/06/2023 09:57, Kamil Konieczny wrote: > > On 2023-06-06 at 19:52:26 +0200, Andi Shyti wrote: > > > From: Fei Yang > > > > > > For platforms other than Meteor Lake the set_pat extension should > > > return -ENODEV. > > > > > > Signed-off-by: Fei Yang > > > Signed-off-by: Andi Shyti > > > --- > > > tests/i915/gem_create.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c > > > index e9e8216d2b..b7961d9ef2 100644 > > > --- a/tests/i915/gem_create.c > > > +++ b/tests/i915/gem_create.c > > > @@ -657,6 +657,7 @@ static void create_ext_set_pat(int fd) > > > .base = { .name = I915_GEM_CREATE_EXT_SET_PAT }, > > > .pat_index = 65, > > > }; > > > + uint32_t devid = intel_get_drm_devid(fd); > > > struct drm_i915_gem_caching arg; > > > uint64_t size; > > > uint32_t handle; > > > @@ -672,6 +673,9 @@ static void create_ext_set_pat(int fd) > > > */ > > > if (ret == -EINVAL) > > > igt_skip("I915_GEM_CREATE_EXT_SET_PAT is not supported\n"); > > > + else if (!IS_METEORLAKE(devid)) > > > + igt_assert_eq(ret, -ENODEV); right, we should have returned from here, if we want to have differentiated printouts... > Hmm a sea of red.. > > https://intel-gfx-ci.01.org/tree/drm-tip/index.html?testfilter=set-pat > > https://intel-gfx-ci.01.org/tree/drm-intel-fixes/CI_DIF_773/shard-snb7/igt@gem_create@create-ext-set-pat.html > > Starting subtest: create-ext-set-pat > (gem_create:1095) CRITICAL: Test assertion failure function create_ext_set_pat, file ../../../usr/src/igt-gpu-tools/tests/i915/gem_create.c:679: > (gem_create:1095) CRITICAL: Failed assertion: ret == 0 > Subtest create-ext-set-pat failed. > > Not sure why shards run did not flag this (?!), but AFAICT the logic does not work. > > It should be igt_skip on MTL, otherwise.. > > > > + > > > > lgtm, > > > > Reviewed-by: Kamil Konieczny > > > > > igt_assert(ret == 0); > > .. test just fails here. So something like: > > igt_skip_on_f(ret == -EINVAL || (ret == -ENODEV && IS_METEORLAKE(devid)), "...") But I guess this is also right! I will fix it. Thanks, Tvrtko! Andi > ? > > Regards, > > Tvrtko > > > > /* > > > -- > > > 2.40.1 > > >