From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 78E3E10E6F4 for ; Fri, 21 Jul 2023 20:25:27 +0000 (UTC) Date: Fri, 21 Jul 2023 16:25:10 -0400 From: Rodrigo Vivi To: Matthew Brost Message-ID: References: <20230721043735.205229-1-matthew.brost@intel.com> <20230721043735.205229-4-matthew.brost@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230721043735.205229-4-matthew.brost@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH 4/5] xe_vm: Unmap BOs in bind queue independent test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, Jul 20, 2023 at 09:37:34PM -0700, Matthew Brost wrote: > Unmaps also exercise the bind conflict logic in Xe, add an unmap to the > bind queue independent test to further test the conflict logic. > > v2: new commit message (Rodrigo) Thanks for this and for the extra explanation offline. > > Signed-off-by: Matthew Brost > --- > tests/xe/xe_vm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/xe/xe_vm.c b/tests/xe/xe_vm.c > index 5fd511f0b8..36cd803577 100644 > --- a/tests/xe/xe_vm.c > +++ b/tests/xe/xe_vm.c > @@ -811,6 +811,12 @@ test_bind_engines_independent(int fd, struct drm_xe_engine_class_instance *eci) > NULL)); > igt_assert_eq(data[0].data, 0xc0ffee); > > + syncobj_destroy(fd, sync[0].handle); > + sync[0].handle = syncobj_create(fd, 0); > + sync[0].flags |= DRM_XE_SYNC_SIGNAL; > + xe_vm_unbind_all_async(fd, vm, 0, bo, sync, 1); > + igt_assert(syncobj_wait(fd, &sync[0].handle, 1, INT64_MAX, 0, NULL)); it looks like this would work even without the conflict logic, but yeap, it will exercise that piece of tree, and it doesn't hurt. So, let's move with it: Reviewed-by: Rodrigo Vivi > + > syncobj_destroy(fd, sync[0].handle); > for (i = 0; i < N_ENGINES; i++) { > syncobj_destroy(fd, syncobjs[i]); > -- > 2.34.1 >