From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id DB15E10E046
 for <igt-dev@lists.freedesktop.org>; Fri,  8 Sep 2023 09:16:02 +0000 (UTC)
Date: Fri, 8 Sep 2023 11:15:46 +0200
From: Francois Dugast <francois.dugast@intel.com>
To: Zbigniew =?utf-8?Q?Kempczy=C5=84ski?= <zbigniew.kempczynski@intel.com>
Message-ID: <ZPrmQvmQGuRjn3DN@fdugast-desk.home>
References: <20230905133309.365109-1-zbigniew.kempczynski@intel.com>
 <20230905133309.365109-7-zbigniew.kempczynski@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230905133309.365109-7-zbigniew.kempczynski@intel.com>
MIME-Version: 1.0
Subject: Re: [igt-dev] [PATCH i-g-t v2 6/9] intel/gem_compute: Add test
 which runs compute workload on i915
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Tue, Sep 05, 2023 at 03:33:06PM +0200, Zbigniew Kempczyński wrote:
> This test is verbatim copy of xe_compute with driver open exception
> (it opens i915 drm fd instead xe). Technically it is possible to
> create single test code (open would try DEVICE_INTEL | DEVICE_XE)
> but I resisted to that distinguishing i915 and xe version.
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Christoph Manszewski <christoph.manszewski@intel.com>
> Cc: Francois Dugast <francois.dugast@intel.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>

Reviewed-by: Francois Dugast <francois.dugast@intel.com>

> ---
>  tests/intel/gem_compute.c | 46 +++++++++++++++++++++++++++++++++++++++
>  tests/meson.build         |  1 +
>  2 files changed, 47 insertions(+)
>  create mode 100644 tests/intel/gem_compute.c
> 
> diff --git a/tests/intel/gem_compute.c b/tests/intel/gem_compute.c
> new file mode 100644
> index 0000000000..b408efee16
> --- /dev/null
> +++ b/tests/intel/gem_compute.c
> @@ -0,0 +1,46 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2023 Intel Corporation
> + */
> +
> +/**
> + * TEST: Check compute-related functionality
> + * Category: Hardware building block
> + * Sub-category: compute
> + * Test category: functionality test
> + * Run type: BAT
> + */
> +
> +#include <string.h>
> +
> +#include "igt.h"
> +#include "intel_compute.h"
> +
> +/**
> + * SUBTEST: compute-square
> + * GPU requirement: only works on TGL
> + * Description:
> + *	Run an openCL Kernel that returns output[i] = input[i] * input[i],
> + *	for an input dataset..
> + * Functionality: compute openCL kernel
> + * TODO: extend test to cover other platforms
> + */
> +static void
> +test_compute_square(int fd)
> +{
> +	igt_require_f(run_compute_kernel(fd), "GPU not supported\n");
> +}
> +
> +igt_main
> +{
> +	int i915;
> +
> +	igt_fixture
> +		i915 = drm_open_driver(DRIVER_INTEL);
> +
> +	igt_subtest("compute-square")
> +		test_compute_square(i915);
> +
> +	igt_fixture
> +		drm_close_driver(i915);
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index aa8e3434ce..03bb7785c3 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -105,6 +105,7 @@ intel_i915_progs = [
>  	'gem_ccs',
>  	'gem_close',
>  	'gem_close_race',
> +	'gem_compute',
>  	'gem_concurrent_blit',
>  	'gem_cs_tlb',
>  	'gem_ctx_bad_destroy',
> -- 
> 2.34.1
>