From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 725CD10E114 for ; Wed, 13 Sep 2023 22:06:00 +0000 (UTC) Date: Wed, 13 Sep 2023 15:05:54 -0700 From: Niranjana Vishwanathapura To: Matthew Brost Message-ID: References: <20230912234954.2110973-1-matthew.brost@intel.com> <20230912234954.2110973-2-matthew.brost@intel.com> Content-Type: text/plain; charset="us-ascii"; format=flowed Content-Disposition: inline In-Reply-To: <20230912234954.2110973-2-matthew.brost@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH 1/2] xe_exec_threads: Use DRM_XE_VM_CREATE_COMPUTE_MODE when creating a compute VM List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Tue, Sep 12, 2023 at 04:49:53PM -0700, Matthew Brost wrote: >XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE was used creating a compute VM. >This just happened to work as it is same value as >DRM_XE_VM_CREATE_COMPUTE_MODE. Fix this and use correct flag, >DRM_XE_VM_CREATE_COMPUTE_MODE. > Reviewed-by: Niranjana Vishwanathapura >Signed-off-by: Matthew Brost >--- > tests/intel/xe_exec_threads.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/tests/intel/xe_exec_threads.c b/tests/intel/xe_exec_threads.c >index ae4da0568a..34bcb3d4d5 100644 >--- a/tests/intel/xe_exec_threads.c >+++ b/tests/intel/xe_exec_threads.c >@@ -286,7 +286,7 @@ test_compute_mode(int fd, uint32_t vm, uint64_t addr, uint64_t userptr, > > if (!vm) { > vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS | >- XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, 0); >+ DRM_XE_VM_CREATE_COMPUTE_MODE, 0); > owns_vm = true; > } > >@@ -1075,7 +1075,7 @@ static void threads(int fd, int flags) > to_user_pointer(&ext)); > vm_compute_mode = xe_vm_create(fd, > DRM_XE_VM_CREATE_ASYNC_BIND_OPS | >- XE_EXEC_QUEUE_SET_PROPERTY_COMPUTE_MODE, >+ DRM_XE_VM_CREATE_COMPUTE_MODE, > 0); > > vm_err_thread.capture = &capture; >-- >2.34.1 >