From: Andi Shyti <andi.shyti@linux.intel.com>
To: Lee Shawn C <shawn.c.lee@intel.com>
Cc: igt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH] tests: save GPU engine information more properly
Date: Fri, 13 Oct 2023 20:41:29 +0200 [thread overview]
Message-ID: <ZSmPWdt1yFbh23xy@ashyti-mobl2.lan> (raw)
In-Reply-To: <20231013042012.409376-1-shawn.c.lee@intel.com>
Hi Shawn,
without the i-g-t tag in the title this path was picked up by the
kernel's patchwork.
Can you please use the [PATCH i-g-t] tag?
On Fri, Oct 13, 2023 at 12:20:12PM +0800, Lee Shawn C wrote:
> We encounter a unexpected error on chrome book device while
> running kms_busy test. It will restore GPU engine's timeout
> value but open incorrect file name (XR24 in below).
>
> openat(AT_FDCWD, "/sys/dev/char/226:0", O_RDONLY) = 12
> openat(12, "dev", O_RDONLY) = 13
> read(13, "226:0\n", 1023) = 6
> close(13) = 0
> openat(12, "engine", O_RDONLY) = 13
> close(12) = 0
> openat(13, "XR24", O_RDONLY) = -1 ENOENT (No such file or directory)
>
> Test code did not save engine data properly to cause this problem.
> So modify the code to save GPU engine information into a globla variable
> to avoid test deamon to open incorrect file again.
>
> Issue: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/147
> Fixes: 9e635a1c5029 ("tests/kms_busy: Ensure GPU reset when waiting
> for a new FB during modeset")
please don't break the Fixes: line.
Andi
next prev parent reply other threads:[~2023-10-13 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 4:20 [igt-dev] [PATCH] tests: save GPU engine information more properly Lee Shawn C
2023-10-13 4:55 ` [igt-dev] ✓ CI.xeBAT: success for " Patchwork
2023-10-13 5:15 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-10-13 7:47 ` [igt-dev] [PATCH] " Tvrtko Ursulin
2023-10-13 18:41 ` Andi Shyti [this message]
2023-10-14 4:23 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZSmPWdt1yFbh23xy@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=shawn.c.lee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox