Re: [igt-dev] [PATCH i-g-t 1/2] tests/intel/kms_pm_rpm: use linear modifier

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Oct 12, 2023 at 11:44:43AM +0530, Swati Sharma wrote:
> To setup primary plane, use DRM_FORMAT_MOD_LINEAR instead of
> I915_FORMAT_MOD_X_TILED.

I don't believe we had any strong reason for the X_tile, so:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>  tests/intel/kms_pm_rpm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/intel/kms_pm_rpm.c b/tests/intel/kms_pm_rpm.c
> index 2882e265f..a46735875 100644
> --- a/tests/intel/kms_pm_rpm.c
> +++ b/tests/intel/kms_pm_rpm.c
> @@ -1305,13 +1305,13 @@ static void test_one_plane(bool dpms, uint32_t plane_id,
>  		plane_format = DRM_FORMAT_XRGB8888;
>  		plane_w = 64;
>  		plane_h = 64;
> -		modifier = I915_FORMAT_MOD_X_TILED;
> +		modifier = DRM_FORMAT_MOD_LINEAR;
>  		break;
>  	case PLANE_PRIMARY:
>  		plane_format = DRM_FORMAT_XRGB8888;
>  		plane_w = default_mode_params->mode->hdisplay;
>  		plane_h = default_mode_params->mode->vdisplay;
> -		modifier = I915_FORMAT_MOD_X_TILED;
> +		modifier = DRM_FORMAT_MOD_LINEAR;
>  		break;
>  	case PLANE_CURSOR:
>  		plane_format = DRM_FORMAT_ARGB8888;
> -- 
> 2.25.1
>