From: Petri Latvala <adrinael@adrinael.net>
To: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] igt_runner: output planned job_list tasks in dry-run mode
Date: Fri, 20 Oct 2023 16:18:40 +0300 [thread overview]
Message-ID: <ZTJ+MDme83/yhZIy@adrinael.net> (raw)
In-Reply-To: <20231020102146.121478-3-mauro.chehab@linux.intel.com>
On Fri, Oct 20, 2023 at 12:20:33PM +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>
> If igt_runner is executed in dry-run mode, show what jobs
> were planned to be executed. That helps debugging issues at
> the runner job plan logic.
If you only need this for debugging, look at the job list file the dry
run created.
--
Petri Latvala
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> ---
> runner/executor.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/runner/executor.c b/runner/executor.c
> index d3e6296dd6d8..3b9e39f4001b 100644
> --- a/runner/executor.c
> +++ b/runner/executor.c
> @@ -2287,6 +2287,12 @@ bool execute(struct execute_state *state,
> bool status = true;
>
> if (state->dry) {
> + for (; state->next < job_list->size; state->next++) {
> + char *job_name;
> +
> + job_name = entry_display_name(&job_list->entries[state->next]);
> + outf("dry-run: %s\n", job_name);
> + }
> outf("Dry run, not executing. Invoke igt_resume if you want to execute.\n");
> return true;
> }
> --
> 2.41.0
>
next prev parent reply other threads:[~2023-10-20 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 10:20 [igt-dev] [PATCH i-g-t 0/2] Improve IGT runner dry-run logic Mauro Carvalho Chehab
2023-10-20 10:20 ` [igt-dev] [PATCH i-g-t 1/2] igt_runner: don't require root for dry_run Mauro Carvalho Chehab
2023-10-20 11:27 ` Kamil Konieczny
2023-10-20 10:20 ` [igt-dev] [PATCH i-g-t 2/2] igt_runner: output planned job_list tasks in dry-run mode Mauro Carvalho Chehab
2023-10-20 11:29 ` Kamil Konieczny
2023-10-20 13:18 ` Petri Latvala [this message]
2023-10-23 23:48 ` [igt-dev] ✓ Fi.CI.BAT: success for Improve IGT runner dry-run logic Patchwork
2023-10-24 0:46 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTJ+MDme83/yhZIy@adrinael.net \
--to=adrinael@adrinael.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=mauro.chehab@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox