From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4F6C910E62A for ; Wed, 29 Nov 2023 16:07:32 +0000 (UTC) Date: Wed, 29 Nov 2023 09:05:46 +0000 From: Matthew Brost To: Francois Dugast Message-ID: References: <20231129145457.7-1-francois.dugast@intel.com> <20231129145457.7-15-francois.dugast@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231129145457.7-15-francois.dugast@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH v4 14/20] drm-uapi/xe: Kill tile_mask List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Wed, Nov 29, 2023 at 02:54:51PM +0000, Francois Dugast wrote: > Align with commit ("drm/xe/uapi: Kill tile_mask") > > Signed-off-by: Francois Dugast Reviewed-by: Matthew Brost > --- > include/drm-uapi/xe_drm.h | 8 +------- > tests/intel/xe_vm.c | 1 - > 2 files changed, 1 insertion(+), 8 deletions(-) > > diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h > index 1e98363b2..2a4ac6e8e 100644 > --- a/include/drm-uapi/xe_drm.h > +++ b/include/drm-uapi/xe_drm.h > @@ -683,12 +683,6 @@ struct drm_xe_vm_bind_op { > /** @addr: Address to operate on, MBZ for UNMAP_ALL */ > __u64 addr; > > - /** > - * @tile_mask: Mask for which tiles to create binds for, 0 == All tiles, > - * only applies to creating new VMAs > - */ > - __u64 tile_mask; > - > #define DRM_XE_VM_BIND_OP_MAP 0x0 > #define DRM_XE_VM_BIND_OP_UNMAP 0x1 > #define DRM_XE_VM_BIND_OP_MAP_USERPTR 0x2 > @@ -723,7 +717,7 @@ struct drm_xe_vm_bind_op { > __u32 prefetch_mem_region_instance; > > /** @reserved: Reserved */ > - __u64 reserved[2]; > + __u64 reserved[3]; > }; > > struct drm_xe_vm_bind { > diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c > index 7871fa789..4122b5e49 100644 > --- a/tests/intel/xe_vm.c > +++ b/tests/intel/xe_vm.c > @@ -799,7 +799,6 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, > bind_ops[i].obj_offset = 0; > bind_ops[i].range = bo_size; > bind_ops[i].addr = addr; > - bind_ops[i].tile_mask = 0x1 << eci->gt_id; > bind_ops[i].op = DRM_XE_VM_BIND_OP_MAP; > bind_ops[i].flags = DRM_XE_VM_BIND_FLAG_ASYNC; > bind_ops[i].prefetch_mem_region_instance = 0; > -- > 2.34.1 >