From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA53710E02B for ; Thu, 30 Nov 2023 20:07:45 +0000 (UTC) Date: Thu, 30 Nov 2023 15:07:34 -0500 From: Rodrigo Vivi To: Francois Dugast Message-ID: References: <20231130184536.7-1-francois.dugast@intel.com> <20231130184536.7-18-francois.dugast@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20231130184536.7-18-francois.dugast@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH v5 17/21] drm-uapi/xe: Fix various struct padding for 64b alignment List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Thu, Nov 30, 2023 at 06:45:32PM +0000, Francois Dugast wrote: > Align with commit ("drm/xe/uapi: Fix various struct padding for > 64b alignment") > > Signed-off-by: Francois Dugast Reviewed-by: Rodrigo Vivi > --- > include/drm-uapi/xe_drm.h | 21 ++++++++++++--------- > 1 file changed, 12 insertions(+), 9 deletions(-) > > diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h > index b703dc7ce..3938e553d 100644 > --- a/include/drm-uapi/xe_drm.h > +++ b/include/drm-uapi/xe_drm.h > @@ -211,8 +211,6 @@ struct drm_xe_mem_region { > * a unique pair. > */ > __u16 instance; > - /** @pad: MBZ */ > - __u32 pad; > /** > * @min_page_size: Min page-size in bytes for this region. > * > @@ -381,6 +379,8 @@ struct drm_xe_gt { > __u16 tile_id; > /** @gt_id: Unique ID of this GT within the PCI Device */ > __u16 gt_id; > + /** @pad: MBZ */ > + __u16 pad[3]; > /** @reference_clock: A clock frequency for timestamp */ > __u32 reference_clock; > /** > @@ -600,7 +600,7 @@ struct drm_xe_gem_create { > #define DRM_XE_GEM_CPU_CACHING_WC 2 > __u16 cpu_caching; > /** @pad: MBZ */ > - __u16 pad; > + __u16 pad[3]; > > /** @reserved: Reserved */ > __u64 reserved[2]; > @@ -775,6 +775,9 @@ struct drm_xe_vm_bind_op { > */ > __u32 prefetch_mem_region_instance; > > + /** @pad: MBZ */ > + __u32 pad2; > + > /** @reserved: Reserved */ > __u64 reserved[3]; > }; > @@ -793,12 +796,12 @@ struct drm_xe_vm_bind { > */ > __u32 exec_queue_id; > > - /** @num_binds: number of binds in this IOCTL */ > - __u32 num_binds; > - > /** @pad: MBZ */ > __u32 pad; > > + /** @num_binds: number of binds in this IOCTL */ > + __u32 num_binds; > + > union { > /** @bind: used if num_binds == 1 */ > struct drm_xe_vm_bind_op bind; > @@ -810,12 +813,12 @@ struct drm_xe_vm_bind { > __u64 vector_of_binds; > }; > > + /** @pad: MBZ */ > + __u32 pad2; > + > /** @num_syncs: amount of syncs to wait on */ > __u32 num_syncs; > > - /** @pad2: MBZ */ > - __u32 pad2; > - > /** @syncs: pointer to struct drm_xe_sync array */ > __u64 syncs; > > -- > 2.34.1 >