Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <saurabhg.gupta@intel.com>
Subject: Re: [PATCH i-g-t 1/2] tests/xe_spin_batch: Correct xe_vm_bind_async usage
Date: Sat, 24 Feb 2024 03:40:28 +0000	[thread overview]
Message-ID: <ZdllLKLxAQPYzg3W@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <20240223230407.1712361-2-jonathan.cavitt@intel.com>

On Fri, Feb 23, 2024 at 03:04:06PM -0800, Jonathan Cavitt wrote:
> The third parameter of xe_vm_bind_async is the exec_queue id, not the gt
> id.  Set it to 0 in the preempter, as there should not be an exec_queue
> at the time of execution.
> 
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> ---
>  tests/intel/xe_spin_batch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_spin_batch.c b/tests/intel/xe_spin_batch.c
> index c183063507..faf569baf8 100644
> --- a/tests/intel/xe_spin_batch.c
> +++ b/tests/intel/xe_spin_batch.c
> @@ -198,7 +198,7 @@ static void preempter(int fd, struct drm_xe_engine_class_instance *hwe)
>  			  vram_if_possible(fd, hwe->gt_id),
>  			  DRM_XE_GEM_CREATE_FLAG_NEEDS_VISIBLE_VRAM);
>  
> -	xe_vm_bind_async(fd, vm, hwe->gt_id, bo, 0, addr, bo_size, &sync, 1);
> +	xe_vm_bind_async(fd, vm, 0, bo, 0, addr, bo_size, &sync, 1);
>  	data = xe_bo_map(fd, bo, bo_size);
>  	store_dword_batch(data, addr, value);
>  
> -- 
> 2.25.1
> 

  reply	other threads:[~2024-02-24  3:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 23:04 [PATCH i-g-t 0/2] tests/xe_spin_batch: Miscellaneous preempter fixes Jonathan Cavitt
2024-02-23 23:04 ` [PATCH i-g-t 1/2] tests/xe_spin_batch: Correct xe_vm_bind_async usage Jonathan Cavitt
2024-02-24  3:40   ` Matthew Brost [this message]
2024-02-23 23:04 ` [PATCH i-g-t 2/2] tests/xe_spin_batch: Sync after vm_bind_async Jonathan Cavitt
2024-02-24  3:41   ` Matthew Brost
2024-02-23 23:46 ` ✓ CI.xeBAT: success for tests/xe_spin_batch: Miscellaneous preempter fixes Patchwork
2024-02-24  0:02 ` ✓ Fi.CI.BAT: " Patchwork
2024-02-24 17:09 ` ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdllLKLxAQPYzg3W@DUT025-TGLU.fm.intel.com \
    --to=matthew.brost@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jonathan.cavitt@intel.com \
    --cc=saurabhg.gupta@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox