From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D12E9C54E58 for ; Wed, 20 Mar 2024 09:42:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B9EB910F47B; Wed, 20 Mar 2024 09:42:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="PY+DTVR/"; dkim-atps=neutral Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by gabe.freedesktop.org (Postfix) with ESMTPS id 739A110F457 for ; Wed, 20 Mar 2024 09:42:08 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 31AB720012; Wed, 20 Mar 2024 09:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1710927726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tt4ZC7hm1BRp/Q5l1V0PUFovw3Gz1spvHkZRP0saRe0=; b=PY+DTVR/R2zTAZ4YFcS27RmBXdxJN0fSzHFtepljFuaX6wkAm1DDnjMCnYKimoaJXxDmaI aaF2owq+SwHgGOFnFZHXZHGjLyKbCwR50D5Nonb5Ynggfgj2UXSTYB/oP5eBBQU6ug7VDe 08pjTkkrW0hZEd/Tl2fy4dRt3iJFqkaDJbEIysK3wbMJOCufUvHrcL/jfypalloRIcARzy YNoN1kDDyN1W7BJFVTy6TBEMqrQloHP5pJrUak1gR+Te57RMoN8vOuNLTxSkpVvAVYSMCV V9epvEJcAQ+9/0v9uROJWBEeVIA9607kSljHmb36wFSm8NqJgEkIvtKdoHxbpQ== Date: Wed, 20 Mar 2024 10:42:03 +0100 From: Louis Chauvet To: Kamil Konieczny Cc: igt-dev@lists.freedesktop.org, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, jeremie.dautheribes@bootlin.com, arthurgrillo@riseup.net, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com, Ashutosh Dixit , Bhanuprakash Modem , Juha-Pekka Heikkila , Petri Latvala Subject: Re: [PATCH i-g-t] CONTRIBUTING: Add coding style guidelines Message-ID: References: <20240315-add_coding_style-v1-1-50ad93cfa250@bootlin.com> <20240318114329.drrzkqmirdaahigm@kamilkon-desk.igk.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240318114329.drrzkqmirdaahigm@kamilkon-desk.igk.intel.com> X-GND-Sasl: louis.chauvet@bootlin.com X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Le 18/03/24 - 12:43, Kamil Konieczny a écrit : > Hi Louis, > On 2024-03-15 at 17:08:37 +0100, Louis Chauvet wrote: > > As explained in [1], the submitted patches should follow the same style as > > the Linux kernel and must be checked against checkpatch.pl, so add this > > recommendation in the CONTRIBUTING.md file. > > > > [1]: https://lore.kernel.org/all/20240314170643.77vzqqoie2otyu4w@kamilkon-desk.igk.intel.com/ > > > > Signed-off-by: Louis Chauvet > > > > To: igt-dev@lists.freedesktop.org > -^^^^^^^^^^^^^^ > Drop this. > > > Cc: miquel.raynal@bootlin.com > > Cc: thomas.petazzoni@bootlin.com > > Cc: jeremie.dautheribes@bootlin.com > > Cc: arthurgrillo@riseup.net > > Cc: seanpaul@google.com > > Cc: marcheu@google.com > > Cc: nicolejadeyee@google.com > > Cc: kamil.konieczny@linux.intel.com > > These should be before your s-o-b above. > I will add here few more maintainers: > > Cc: Ashutosh Dixit > Cc: Bhanuprakash Modem > Cc: Juha-Pekka Heikkila > Cc: Petri Latvala > > > --- > > Here you could add your notes which will be ignored by git > at merging but I do not see any? Sorry for this mess. I tried to use b4, but I think I miss something to send only one patch. I will try to avoid this error in v2. > > To: igt-dev@lists.freedesktop.org > > Cc: miquel.raynal@bootlin.com > > Cc: thomas.petazzoni@bootlin.com > > Cc: jeremie.dautheribes@bootlin.com > > Cc: arthurgrillo@riseup.net > > Cc: seanpaul@google.com > > Cc: marcheu@google.com > > Cc: nicolejadeyee@google.com > > Cc: kamil.konieczny@linux.intel.com > > > > Signed-off-by: Louis Chauvet > > --- > > CONTRIBUTING.md | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > > index 2ab8a48f6ae9..ec8debb4091e 100644 > > --- a/CONTRIBUTING.md > > +++ b/CONTRIBUTING.md > > @@ -78,6 +78,8 @@ Sending Patches > > - Changes to the testcases are automatically tested. Take the results into > > account before merging. > > > > +- The coding rules are the same as for the Linux kernel. To check for common > -------------------------^ > insert 'almost' here: s/are the same/are almost the same/ Ack > > + style problems, you need to use the kernel's checkpatch.pl script. > > There are known variations like we do not have MAINTAINERS, or > we allow to use typdefs, allow to have (reasonable) longer lines > and few others differences. If you have a list, maybe I can specify the command line to use? Kind regards, Louis Chauvet > Regards, > Kamil > > > > > Commit Rights > > ------------- > > > > --- > > base-commit: ed47dd9fb6b5be6c88513c2816f0f7cfdd0e02f6 > > change-id: 20240315-add_coding_style-b755454de958 > > > > Best regards, > > -- > > Louis Chauvet > > -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com