Re: [PATCH i-g-t 0/9] enhancements for forcing debugfs of connector

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Apr 10, 2024 at 12:14:17PM +0530, Kunal Joshi wrote:
> We have kmstest_force_connector that allows forcing a state
> to status sysfs, use the same mechanism for debugfs as well.
> Haven't reused the kmstest_force_connector as its used for sysfs
> and wanted to have seperate flows for debugfs and sysfs.
> 
> patch series adds kmstest_force_connector_debugfs which allows
> set value to particular debugfs of a connector, also it adds an exit
> handler to clear the state at exit.

I had a look at this and thought we could generalize
the code quite a bit. I took a quick stab at doing just
that: https://patchwork.freedesktop.org/series/132284/

> 
> Kunal Joshi (9):
>   lib/igt_kms: Refacror forced_connector struct
>   lib/igt_kms: add forced_connectors_debugfs array
>   lib/igt_kms: add enum kmstest_force_type
>   lib/igt_kms: refactor helpers forced_connectors helpers
>   lib/igt_kms: add igt_reset_connectors_debugfs
>   lib/igt_kms: add exit handler function to clear force debugfs state
>   lib/igt_kms: add kmstest_force_connector_debugfs
>   tests/intel/km_big_joiner: use kmstest_force_connector_debugfs for
>     better cleanup functionality
>   lib/igt_kms: remove unused igt_force_and_check_bigjoiner_status
> 
>  lib/igt_kms.c                | 203 +++++++++++++++++++++++++++--------
>  lib/igt_kms.h                |  25 ++++-
>  tests/intel/kms_big_joiner.c |  23 ++--
>  3 files changed, 193 insertions(+), 58 deletions(-)
> 
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel