From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Arthur Grillo <arthurgrillo@riseup.net>
Cc: igt-dev@lists.freedesktop.org,
Petri Latvala <adrinael@adrinael.net>,
Arkadiusz Hiler <arek@hiler.eu>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Pekka Paalanen <pekka.paalanen@collabora.com>
Subject: Re: [PATCH i-g-t v5 2/8] benchmarks/kms_fb_stress: Log the KMS structure
Date: Wed, 22 May 2024 10:51:50 +0200 [thread overview]
Message-ID: <Zk2yJu0ow22TR0Gb@localhost.localdomain> (raw)
In-Reply-To: <20240422-kms_fb_stress-dev-v5-2-0c577163dc88@riseup.net>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Tested-by: Louis Chauvet <louis.chauvet@bootlin.com>
Le 22/04/24 - 19:18, Arthur Grillo a écrit :
> In the future, the KMS structure could be dynamically changed. So, log
> the KMS structure to the user.
>
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
> ---
> benchmarks/kms_fb_stress.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/benchmarks/kms_fb_stress.c b/benchmarks/kms_fb_stress.c
> index e9c051318ed6..8d4707f5a8c0 100644
> --- a/benchmarks/kms_fb_stress.c
> +++ b/benchmarks/kms_fb_stress.c
> @@ -8,6 +8,9 @@
> #define FRAME_COUNT 100
> #define NUM_FBS 2
>
> +#define RECT_FMT "%dx%d%+d%+d"
> +#define RECT_ARG(r) (r)->width, (r)->height, (r)->x, (r)->y
> +
> struct rect_t {
> int x, y;
> int width, height;
> @@ -187,6 +190,22 @@ igt_simple_main
>
> gen_fbs(&data);
>
> + igt_info("KMS structure:\n");
> + igt_info("\tCRTC:\n");
> + igt_info("\t\trectangle: " RECT_FMT "\n", RECT_ARG(&data.kms.crtc));
> + igt_info("\tprimary:\n");
> + igt_info("\t\tformat: %s\n", igt_format_str(data.kms.primary.format));
> + igt_info("\t\trectangle: " RECT_FMT "\n", RECT_ARG(&data.kms.primary.rect));
> + igt_info("\toverlay A:\n");
> + igt_info("\t\tformat: %s\n", igt_format_str(data.kms.overlay_a.format));
> + igt_info("\t\trectangle: " RECT_FMT "\n", RECT_ARG(&data.kms.overlay_a.rect));
> + igt_info("\toverlay B:\n");
> + igt_info("\t\tformat: %s\n", igt_format_str(data.kms.overlay_b.format));
> + igt_info("\t\trectangle: " RECT_FMT "\n", RECT_ARG(&data.kms.overlay_b.rect));
> + igt_info("\twriteback:\n");
> + igt_info("\t\tformat: %s\n", igt_format_str(data.kms.writeback.format));
> + igt_info("\t\trectangle: " RECT_FMT "\n", RECT_ARG(&data.kms.writeback.rect));
> +
> data.kms.primary.base = igt_output_get_plane_type(data.wb_output, DRM_PLANE_TYPE_PRIMARY);
> igt_assert(data.kms.primary.base != NULL);
>
>
> --
> 2.44.0
>
--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-05-22 8:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-22 22:18 [PATCH i-g-t v5 0/8] benchmarks/kms_fb_stress: benchmark formats Arthur Grillo
2024-04-22 22:18 ` [PATCH i-g-t v5 1/8] benchmarks/kms_fb_stress: Assert that we have an supported pipe Arthur Grillo
2024-05-22 8:50 ` Louis Chauvet
2024-04-22 22:18 ` [PATCH i-g-t v5 2/8] benchmarks/kms_fb_stress: Log the KMS structure Arthur Grillo
2024-05-22 8:51 ` Louis Chauvet [this message]
2024-04-22 22:18 ` [PATCH i-g-t v5 3/8] benchmarks/kms_fb_stress: Separate the benchmark in a subtest Arthur Grillo
2024-05-22 8:59 ` Louis Chauvet
2024-04-22 22:18 ` [PATCH i-g-t v5 4/8] benchmarks/kms_fb_stress: Free resources on the stress procedure Arthur Grillo
2024-05-22 9:04 ` Louis Chauvet
2024-04-22 22:18 ` [PATCH i-g-t v5 5/8] benchmarks/kms_fb_stress: Move FB creation to a separate function Arthur Grillo
2024-05-22 9:07 ` Louis Chauvet
2024-04-22 22:18 ` [PATCH i-g-t v5 6/8] benchmarks/kms_fb_stress: Don't paint the FB's if the format is not supported by Pixman Arthur Grillo
2024-05-22 8:39 ` Louis Chauvet
2024-04-22 22:18 ` [PATCH i-g-t v5 7/8] benchmarks/kms_fb_stress: Optionally enable the overlay planes Arthur Grillo
2024-05-22 9:07 ` Louis Chauvet
2024-04-22 22:18 ` [PATCH i-g-t v5 8/8] benchmarks/kms_fb_stress: Create a benchmark for formats Arthur Grillo
2024-05-22 8:35 ` Louis Chauvet
2024-04-22 23:02 ` ✓ CI.xeBAT: success for benchmarks/kms_fb_stress: benchmark formats (rev2) Patchwork
2024-04-22 23:13 ` ✓ Fi.CI.BAT: " Patchwork
2024-04-23 5:53 ` ✗ CI.xeFULL: failure " Patchwork
2024-04-23 19:57 ` Kamil Konieczny
2024-04-23 10:47 ` ✗ Fi.CI.IGT: " Patchwork
2024-04-23 19:56 ` Kamil Konieczny
2024-05-21 15:57 ` [PATCH i-g-t v5 0/8] benchmarks/kms_fb_stress: benchmark formats Arthur Grillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk2yJu0ow22TR0Gb@localhost.localdomain \
--to=louis.chauvet@bootlin.com \
--cc=adrinael@adrinael.net \
--cc=arek@hiler.eu \
--cc=arthurgrillo@riseup.net \
--cc=ashutosh.dixit@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=pekka.paalanen@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox