Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: <janga.rahul.kumar@intel.com>, <igt-dev@lists.freedesktop.org>,
	<ramadevi.gandi@intel.com>, <badal.nilawar@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/xe_pm: Disable display for mocs-rpm test
Date: Thu, 16 May 2024 15:33:39 -0400	[thread overview]
Message-ID: <ZkZfk19wfBUFnu6d@intel.com> (raw)
In-Reply-To: <knii2c3mppj6gcz33qfvevgm7fe5x5563m56jg3bb2qsa7praa@gnjlqbfee7wn>

On Thu, May 16, 2024 at 11:21:45AM -0500, Lucas De Marchi wrote:
> On Thu, May 16, 2024 at 04:15:13PM GMT, janga.rahul.kumar@intel.com wrote:
> > From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> > 
> > If display is enabled, the always-on components will always keeps
> > runtime pm references, unless you put DPMS_OFF.
> > 
> > Cc: Badal Nilawar <badal.nilawar@intel.com>
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> 
> I think this is
> 
> 	Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1818

very likely yes

> 
> right?
> 
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
> 
> thanks
> Lucas De Marchi
> 
> > ---
> > tests/intel/xe_pm.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
> > index 9cb00c7f1..b4a8c4d15 100644
> > --- a/tests/intel/xe_pm.c
> > +++ b/tests/intel/xe_pm.c
> > @@ -835,8 +835,11 @@ igt_main
> > 			igt_pm_set_autosuspend_delay(device.pci_xe, delay_ms);
> > 		}
> > 
> > -		igt_subtest("mocs-rpm")
> > +		igt_subtest("mocs-rpm") {
> > +			dpms_on_off(device, DRM_MODE_DPMS_OFF);
> > 			test_mocs_suspend_resume(device, NO_SUSPEND);
> > +			dpms_on_off(device, DRM_MODE_DPMS_ON);
> > +		}
> > 	}
> > 
> > 	igt_fixture {
> > -- 
> > 2.25.1
> > 

  reply	other threads:[~2024-05-16 19:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 10:45 [PATCH i-g-t] tests/intel/xe_pm: Disable display for mocs-rpm test janga.rahul.kumar
2024-05-16 11:29 ` ✓ CI.xeBAT: success for " Patchwork
2024-05-16 12:18 ` [PATCH i-g-t] " Rodrigo Vivi
2024-05-16 12:51 ` ✓ CI.xeFULL: success for " Patchwork
2024-05-16 16:21 ` [PATCH i-g-t] " Lucas De Marchi
2024-05-16 19:33   ` Rodrigo Vivi [this message]
2024-05-17  4:20     ` Kumar, Janga Rahul
2024-05-16 17:07 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-05-17  8:26 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-17 15:18   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZkZfk19wfBUFnu6d@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=janga.rahul.kumar@intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=ramadevi.gandi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox