Re: [PATCH i-g-t v4 2/2] test/intel/xe_exec_reset: Synchronize cm-gt-reset gt resets

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Jun 05, 2024 at 10:58:43AM -0700, Jonathan Cavitt wrote:
> The cm-gt-reset test has the potential to race with itself on the gt
> reset, so force the gt reset to be synchronous here.  The race condition
> occurs because the test does not have a fencing mechanism (I.E.
> dma-fence) to protect against this race, unlike in the gt-reset test
> case, for example.
> 
> Suggested-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> CC: John Harrison <john.c.harrison@intel.com>
> CC: Stuart Summers <stuart.summers@intel.com>
> ---
>  tests/intel/xe_exec_reset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_exec_reset.c b/tests/intel/xe_exec_reset.c
> index 05d63c0ba5..817b82cdef 100644
> --- a/tests/intel/xe_exec_reset.c
> +++ b/tests/intel/xe_exec_reset.c
> @@ -530,7 +530,7 @@ test_compute_mode(int fd, struct drm_xe_engine_class_instance *eci,
>  	}
>  
>  	if (flags & GT_RESET)
> -		xe_force_gt_reset_async(fd, eci->gt_id);
> +		xe_force_gt_reset_sync(fd, eci->gt_id);
>  
>  	if (flags & CLOSE_FD) {
>  		if (flags & CLOSE_EXEC_QUEUES) {
> -- 
> 2.25.1
>