Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: <igt-dev@lists.freedesktop.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH i-g-t 0/2] tests/intel/xe_evict: Adapt the working set to memory size
Date: Wed, 26 Jun 2024 17:00:01 +0000	[thread overview]
Message-ID: <ZnxJEc0LC6i7NIhc@DUT025-TGLU.fm.intel.com> (raw)
In-Reply-To: <20240626123833.3164-1-thomas.hellstrom@linux.intel.com>

On Wed, Jun 26, 2024 at 02:38:31PM +0200, Thomas Hellström wrote:
> It turns out that xe_evict in the cm and thread mode is a very good test for
> exhaustive eviction. But the test sometimes uses a working set that doesn't fit

Do to hear that is it is a good test.

Have you tried [1], in particular *evict* sections. I wrote this as an
additional test which also fully checks the integrity of memory as it
gets bounced around. I think this test has value too. It might have a
similar problem to what you fixing in this series though. I think it
worth fixing and getting merged if you may review. I can work on fixing
it if think this has value too so it can be merged.

Anyways will review this series as soon as I can.

Matt

[1] https://patchwork.freedesktop.org/patch/588613/?series=132251&rev=1

> in gpu-accessible memory and a total memory size that exceeds the available
> system size. Attempt to fix that to avoid false failures. With these fixes
> the test should pass unless in -cm mode or multithreaded mode. These require
> fixes for exhaustive eviction in the xe kernel driver.
> 
> Thomas Hellström (2):
>   tests/intel/xe_evict: Reduce allocations to maximum working set
>   tests/intel/xe_evict: Reduce the "large" bo size for threaded eviction
> 
>  tests/intel/xe_evict.c | 126 ++++++++++++++++++++++++++++++++---------
>  1 file changed, 99 insertions(+), 27 deletions(-)
> 
> -- 
> 2.44.0
> 

  parent reply	other threads:[~2024-06-26 17:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 12:38 [PATCH i-g-t 0/2] tests/intel/xe_evict: Adapt the working set to memory size Thomas Hellström
2024-06-26 12:38 ` [PATCH i-g-t 1/2] tests/intel/xe_evict: Reduce allocations to maximum working set Thomas Hellström
2024-06-27  6:29   ` Matthew Brost
2024-06-27  7:28     ` Thomas Hellström
2024-06-26 12:38 ` [PATCH i-g-t 2/2] tests/intel/xe_evict: Reduce the "large" bo size for threaded eviction Thomas Hellström
2024-06-27  6:34   ` Matthew Brost
2024-06-27  7:31     ` Thomas Hellström
2024-06-26 15:20 ` ✗ Fi.CI.BAT: failure for tests/intel/xe_evict: Adapt the working set to memory size Patchwork
2024-06-26 15:23 ` ✓ CI.xeBAT: success " Patchwork
2024-06-26 17:00 ` Matthew Brost [this message]
2024-06-26 21:02 ` ✓ CI.xeFULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZnxJEc0LC6i7NIhc@DUT025-TGLU.fm.intel.com \
    --to=matthew.brost@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox