Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Krzysztof Niemiec <krzysztof.niemiec@intel.com>
Cc: igt-dev@lists.freedesktop.org,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Chris Wilson <chris.p.wilson@linux.intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Nirmoy Das <nirmoy.das@intel.com>,
	Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
	Jann Horn <jannh@google.com>
Subject: Re: [PATCH i-g-t v2 3/3] tests/intel/gem_mmap_offset: Introduce mmap-unmap test
Date: Wed, 21 Aug 2024 16:29:16 +0200	[thread overview]
Message-ID: <ZsX5vGguP77Gy18A@ashyti-mobl2.lan> (raw)
In-Reply-To: <20240821135943.31340-4-krzysztof.niemiec@intel.com>

Hi Krzysztof,

> +	__test_mmap_unmap(args->i915,
> +			  args->r,
> +			  args->limit,
> +			  args->map_size, /* obj_size == map_size in flipper */
> +			  args->map_addr,
> +			  args->map_size,
> +			  args->map_addr,  /* we ignore the poke in flipper thread */
> +			  args->flags,
> +			  false
> +			  );

one nitpick here, the parenthesis should go after false.

Otherwise,

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

Thanks,
Andi

  reply	other threads:[~2024-08-21 14:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 13:59 [PATCH i-g-t v2 0/3] Introduce memory mapping tests Krzysztof Niemiec
2024-08-21 13:59 ` [PATCH i-g-t v2 1/3] tests/intel/gem_mmap_offset: Partial mmap and munmap Krzysztof Niemiec
2024-08-21 14:17   ` Andi Shyti
2024-08-21 13:59 ` [PATCH i-g-t v2 2/3] tests/intel/gem_mmap_offset: Introduce mmap-boundaries test Krzysztof Niemiec
2024-08-21 14:22   ` Andi Shyti
2024-08-21 13:59 ` [PATCH i-g-t v2 3/3] tests/intel/gem_mmap_offset: Introduce mmap-unmap test Krzysztof Niemiec
2024-08-21 14:29   ` Andi Shyti [this message]
2024-08-21 19:31 ` ✓ Fi.CI.BAT: success for Introduce memory mapping tests (rev2) Patchwork
2024-08-21 19:44 ` ✓ CI.xeBAT: " Patchwork
2024-08-22  3:33 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-22  5:05 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZsX5vGguP77Gy18A@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jannh@google.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=krzysztof.niemiec@intel.com \
    --cc=lionel.g.landwerlin@intel.com \
    --cc=nirmoy.das@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox