Re: [PATCH i-g-t 01/14] lib/igt_kms: add enum for link rate and lane count

[Imre Deak <imre.deak@intel.com>]

On Mon, Aug 26, 2024 at 01:35:59AM +0530, Kunal Joshi wrote:
> add enums for link rate, lane count
> 
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
>  lib/igt_kms.h | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 25ba50916..999921f9f 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -258,6 +258,29 @@ enum intel_broadcast_rgb_mode {
>  	BROADCAST_RGB_16_235
>  };
>  
> +enum dp_link_rate {
> +	DP_LINK_RATE_162000 = 162000,
> +	DP_LINK_RATE_216000 = 216000,
> +	DP_LINK_RATE_243000 = 243000,
> +	DP_LINK_RATE_270000 = 270000,
> +	DP_LINK_RATE_324000 = 324000,
> +	DP_LINK_RATE_432000 = 432000,
> +	DP_LINK_RATE_540000 = 540000,
> +	DP_LINK_RATE_675000 = 675000,
> +	DP_LINK_RATE_810000 = 810000,
> +	DP_LINK_RATE_1000000 = 1000000,
> +	DP_LINK_RATE_1350000 = 1350000,
> +	DP_LINK_RATE_2000000 = 2000000
> +};

Imo, there is no point to define enums for the rates or lane counts.

> +
> +#define DP_MAX_LINK_RATE_COUNT 12

This is not used.

> +
> +enum dp_lane_count {
> +	DP_LANE_COUNT_1 = 1,
> +	DP_LANE_COUNT_2 = 2,
> +	DP_LANE_COUNT_4 = 4
> +};
> +
>  struct edid;
>  
>  bool kmstest_force_connector(int fd, drmModeConnector *connector,
> -- 
> 2.34.1
>