Re: [PATCH i-g-t] tests/xe_pm_residency: Fix while loop in toggle_gt_c6

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Sep 19, 2024 at 12:59:50PM -0400, Rodrigo Vivi wrote:
> From: Bommithi Sakeena <bommithi.sakeena@intel.com>
> 
> Function toggle_gt_c6 has while loop iterating for (NUM_REPS +1)
> times. Correct it to iterate to NUM_REPS times.
> 
> Signed-off-by: Bommithi Sakeena <bommithi.sakeena@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/intel/xe_pm_residency.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/intel/xe_pm_residency.c b/tests/intel/xe_pm_residency.c
> index 0e687558b..f4d05889c 100644
> --- a/tests/intel/xe_pm_residency.c
> +++ b/tests/intel/xe_pm_residency.c
> @@ -297,7 +297,7 @@ static void toggle_gt_c6(int fd, int n)
>  
>  		if (n == NUM_REPS)
>  			measure_power(&gpu, &gt_c6_power);
> -	} while (n--);
> +	} while (--n);

Why isn't that just a canonical for loop?

>  
>  	igt_power_close(&gpu);
>  	igt_info("GPU consumed %fmW in GT C6 and %fmW in GT C0\n", gt_c6_power, gt_c0_power);
> -- 
> 2.46.0

-- 
Ville Syrjälä
Intel