From: Imre Deak <imre.deak@intel.com>
To: Kunal Joshi <kunal1.joshi@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t 5/7] lib/igt_kms: Handle EINVAL error as well
Date: Thu, 26 Sep 2024 13:06:40 +0300 [thread overview]
Message-ID: <ZvUyMNT5XDflL6Q3@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20240925182944.1603015-6-kunal1.joshi@intel.com>
On Wed, Sep 25, 2024 at 11:59:42PM +0530, Kunal Joshi wrote:
> Previously, only -ENOSPC was handled, but -EINVAL
> can also occur under certain conditions when the
> mode can't be set.
>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> Suggested-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> lib/igt_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index ca5fc92cd..c96008577 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -4927,7 +4927,7 @@ bool __override_all_active_output_modes_to_fit_bw(igt_display_t *display,
>
> if (!ret)
> return true;
> - else if (ret != -ENOSPC)
> + else if (ret != -ENOSPC && ret != -EINVAL)
> return false;
> }
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-09-26 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 18:29 [PATCH i-g-t 0/7] add test to validate fallback Kunal Joshi
2024-09-25 18:29 ` [PATCH i-g-t 1/7] lib/igt_kms: add DP link management helper functions Kunal Joshi
2024-09-25 18:29 ` [PATCH i-g-t 2/7] lib/igt_kms: allow set and reset value to be same Kunal Joshi
2024-09-25 18:29 ` [PATCH i-g-t 3/7] lib/igt_kms: add function to reset link params Kunal Joshi
2024-09-25 18:29 ` [PATCH i-g-t 4/7] lib/igt_kms: fix helper igt_get_dp_mst_connector_id Kunal Joshi
2024-09-25 18:29 ` [PATCH i-g-t 5/7] lib/igt_kms: Handle EINVAL error as well Kunal Joshi
2024-09-26 10:06 ` Imre Deak [this message]
2024-09-25 18:29 ` [PATCH i-g-t 6/7] tests/intel/kms_dp_linktrain_fallback: add test for validating fallback Kunal Joshi
2024-09-26 10:25 ` Imre Deak
2024-09-26 10:37 ` Joshi, Kunal1
2024-09-25 18:29 ` [PATCH i-g-t 7/7] HAX: Do not merge Kunal Joshi
2024-09-26 7:56 ` ✗ Fi.CI.BAT: failure for add test to validate fallback (rev7) Patchwork
2024-09-26 8:16 ` ✗ CI.xeBAT: " Patchwork
2024-09-26 9:09 ` ✓ Fi.CI.IGT: success " Patchwork
2024-09-26 21:57 ` ✗ CI.xeFULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvUyMNT5XDflL6Q3@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox