Re: [PATCH i-g-t v2] tests/kms_rotation_crc: Intel display version 20 onwards doesn't do hflip with tile4

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Oct 22, 2024 at 12:47:44PM +0300, Juha-Pekka Heikkila wrote:
> On Intel display version 20 Tile4 no longer can be used with horizontal
> flip.
> 
> Bspec: 69853
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  tests/kms_rotation_crc.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 9888ac6ac..d4a1c91cc 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -639,6 +639,14 @@ static void test_plane_rotation(data_t *data, int plane_type, bool test_bad_form
>  			    !IS_CHERRYVIEW(data->devid) ||
>  			    data->rotation != (IGT_ROTATION_180 | IGT_REFLECT_X));
>  
> +		/* Intel display version 20 onwards cannot do reflect-x with
> +		 * tile4
> +		 */
> +		igt_require(!is_intel_device(data->gfx_fd) ||
> +			    intel_display_ver(data->devid) < 20 ||
> +			    !(data->override_modifier == I915_FORMAT_MOD_4_TILED &&
> +			    data->rotation & IGT_REFLECT_X));
> +

This place is getting rather cluttered. Can you extract all the
igt_require() conditions here into a separate function so we'd
just be left with something like
 igt_require(plane_can_rotate(...)); ?

>  		prepare_crtc(data, output, pipe, plane, true);
>  
>  		for (i = 0; i < num_rectangle_types; i++) {
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel