Re: [PATCH i-g-t] lib/igt_kmod: Drop PM interaction on unbind

[Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>]

On Wed, Oct 30, 2024 at 04:48:38PM -0700, Lucas De Marchi wrote:
>Setting the power/control to "auto" is not needed and will fail if
>kernel is configured without CONFIG_PM. Just stop setting it and it
>should still work as before.
>
>Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

LGTM,

Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

Thanks,
Umesh
>---
> lib/igt_kmod.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c
>index 6f73f9220..bcbb8dc22 100644
>--- a/lib/igt_kmod.c
>+++ b/lib/igt_kmod.c
>@@ -690,9 +690,6 @@ static int unbind(const char *driver)
> 		devfd = openat(dirfd(dir), de->d_name, O_RDONLY | O_CLOEXEC);
> 		igt_assert(devfd >= 0);
>
>-		ret = igt_sysfs_set(devfd, "power/control", "auto");
>-		igt_assert(ret);
>-
> 		ret = igt_sysfs_set(devfd, "driver/unbind", de->d_name);
> 		igt_assert(ret);
>
>-- 
>2.47.0
>