From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44DD910E05F for ; Wed, 19 Apr 2023 04:41:22 +0000 (UTC) Message-ID: Date: Wed, 19 Apr 2023 10:11:07 +0530 To: Kamil Konieczny , , Zack Rusin , , , , , , Bhanuprakash Modem , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= References: <20230413012426.503658-1-zack@kde.org> <20230413012426.503658-9-zack@kde.org> <20230417123911.mcrcvgvfes4ritsi@kamilkon-desk1> Content-Language: en-US From: Karthik B S In-Reply-To: <20230417123911.mcrcvgvfes4ritsi@kamilkon-desk1> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v4 8/8] lib: Fix igt_kms for drivers with 8 crtc's List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 4/17/2023 6:09 PM, Kamil Konieczny wrote: > Hi, > > On 2023-04-12 at 21:24:26 -0400, Zack Rusin wrote: >> From: Zack Rusin >> >> To avoid crashes in multiple tests on vmwgfx we need to extend the >> number of available pipe's to be at least as big as the the number >> returned by the virtualized drivers (which is 8). >> >> Signed-off-by: Zack Rusin >> Reviewed-by: Martin Krastev >> Reviewed-by: Maaz Mombasawala > imho this should have no impact on kms tests but I will ask also > Bhanuprakash, Ville and Karthik so +cc them on this. Agreed. Acked-by: Karthik B S > > Regards, > Kamil > >> --- >> lib/igt_kms.c | 2 +- >> lib/igt_kms.h | 2 ++ >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/lib/igt_kms.c b/lib/igt_kms.c >> index 50655f13..a23999cb 100644 >> --- a/lib/igt_kms.c >> +++ b/lib/igt_kms.c >> @@ -840,7 +840,7 @@ static igt_plane_t *igt_get_assigned_primary(igt_output_t *output, igt_pipe_t *p >> */ >> const char *kmstest_pipe_name(enum pipe pipe) >> { >> - static const char str[] = "A\0B\0C\0D\0E\0F"; >> + static const char str[] = "A\0B\0C\0D\0E\0F\0G\0H"; >> >> _Static_assert(sizeof(str) == IGT_MAX_PIPES * 2, >> "Missing pipe name"); >> diff --git a/lib/igt_kms.h b/lib/igt_kms.h >> index 2b917925..d3a39e24 100644 >> --- a/lib/igt_kms.h >> +++ b/lib/igt_kms.h >> @@ -62,6 +62,8 @@ enum pipe { >> PIPE_D, >> PIPE_E, >> PIPE_F, >> + PIPE_G, >> + PIPE_H, >> IGT_MAX_PIPES >> }; >> const char *kmstest_pipe_name(enum pipe pipe); >> -- >> 2.39.2 >>