From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2.
Date: Wed, 27 Feb 2019 15:32:08 +0100 [thread overview]
Message-ID: <a04275bc-7fab-c3e4-5187-bbb1c891a6f0@linux.intel.com> (raw)
In-Reply-To: <20190225191054.GK20097@intel.com>
Op 25-02-2019 om 20:10 schreef Ville Syrjälä:
> On Thu, Feb 14, 2019 at 11:59:01AM +0100, Maarten Lankhorst wrote:
>> Newer platforms don't support this format, but the tests don't check
>> if the format is supported on the primary plane.
> This sentence is rather confusing. Maybe
> "Not all hardware supports all formats, but ..." ?
>
> Otherwise the patch seems sensible to me
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Oops, forgot to change the commit message here, but pushed. :)
Thanks for review. Will add a mental note to be more careful in the future.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-02-27 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 10:59 [igt-dev] [PATCH i-g-t] kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2 Maarten Lankhorst via igt-dev
2019-02-14 11:32 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-02-20 10:57 ` [igt-dev] ✓ Fi.CI.BAT: success for kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2. (rev2) Patchwork
2019-02-20 13:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-25 19:10 ` [igt-dev] [PATCH i-g-t] kms_chamelium: Fix test failures from missing outputs/unsupported formats, v2 Ville Syrjälä
2019-02-27 14:32 ` Maarten Lankhorst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a04275bc-7fab-c3e4-5187-bbb1c891a6f0@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox