From: vitaly prosyak <vprosyak@amd.com>
To: Jesse Zhang <jesse.zhang@amd.com>, igt-dev@lists.freedesktop.org
Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>
Subject: Re: [PATCH i-g-t] tests/amd_dispatch: fix KGQ hang test
Date: Thu, 8 Aug 2024 13:27:42 -0400 [thread overview]
Message-ID: <a05466dc-b7fd-4100-8aee-620f77a7719b@amd.com> (raw)
In-Reply-To: <20240808084058.2704009-1-jesse.zhang@amd.com>
The change looks good to me.
Reviewed-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
On 2024-08-08 04:40, Jesse Zhang wrote:
> Set specific error type for KGQ hang test.
>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
>
> Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
> ---
> tests/amdgpu/amd_dispatch.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/amdgpu/amd_dispatch.c b/tests/amdgpu/amd_dispatch.c
> index 2c17e90ab..76b62128d 100644
> --- a/tests/amdgpu/amd_dispatch.c
> +++ b/tests/amdgpu/amd_dispatch.c
> @@ -26,9 +26,9 @@ amdgpu_dispatch_hang_slow_compute(amdgpu_device_handle device_handle)
> }
>
> static void
> -amdgpu_dispatch_hang_gfx(amdgpu_device_handle device_handle)
> +amdgpu_dispatch_hang_gfx(amdgpu_device_handle device_handle, enum cmd_error_type error)
> {
> - amdgpu_gfx_dispatch_test(device_handle, AMDGPU_HW_IP_GFX, 1);
> + amdgpu_gfx_dispatch_test(device_handle, AMDGPU_HW_IP_GFX, error);
> }
>
> static void
> @@ -118,7 +118,7 @@ igt_main
> igt_subtest_with_dynamic("amdgpu-dispatch-hang-test-gfx-with-IP-GFX") {
> if (arr_cap[AMD_IP_GFX]) {
> igt_dynamic_f("amdgpu-dispatch-hang-test-gfx")
> - amdgpu_dispatch_hang_gfx(device);
> + amdgpu_dispatch_hang_gfx(device, BACKEND_SE_GC_SHADER_INVALID_SHADER);
> }
> }
>
prev parent reply other threads:[~2024-08-08 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 8:40 [PATCH i-g-t] tests/amd_dispatch: fix KGQ hang test Jesse Zhang
2024-08-08 9:42 ` ✓ CI.xeBAT: success for " Patchwork
2024-08-08 9:53 ` ✓ Fi.CI.BAT: " Patchwork
2024-08-08 11:41 ` ✗ CI.xeFULL: failure " Patchwork
2024-08-08 12:37 ` ✗ Fi.CI.IGT: " Patchwork
2024-08-08 17:27 ` vitaly prosyak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a05466dc-b7fd-4100-8aee-620f77a7719b@amd.com \
--to=vprosyak@amd.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jesse.zhang@amd.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=vitaly.prosyak@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox