From: Karthik B S <karthik.b.s@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
<igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t v2 2/2] tests/kms_rotation_crc: Intel display version 20 onwards doesn't do hflip with tile4
Date: Wed, 6 Nov 2024 16:24:06 +0530 [thread overview]
Message-ID: <a0afc98a-338a-4a08-ba86-013b88f15f8d@intel.com> (raw)
In-Reply-To: <20241104194415.563277-2-juhapekka.heikkila@gmail.com>
On 11/5/2024 1:14 AM, Juha-Pekka Heikkila wrote:
> On Intel display version 20 Tile4 no longer can be used with horizontal
> flip.
>
> Bspec: 69853
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tests/kms_rotation_crc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index e8b6e4ff2..22fb5383b 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -577,6 +577,13 @@ static bool plane_rotation_requirements(data_t *data, igt_plane_t *plane)
> data->rotation != (IGT_ROTATION_180 | IGT_REFLECT_X)))
> return false;
>
> + /* Intel display version 20 onwards cannot do reflect-x with tile4 */
> + if (!(!is_intel_device(data->gfx_fd) ||
> + intel_display_ver(data->devid) < 20 ||
> + !(data->override_modifier == I915_FORMAT_MOD_4_TILED &&
> + data->rotation & IGT_REFLECT_X)))
> + return false;
> +
> return true;
> }
>
next prev parent reply other threads:[~2024-11-06 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 19:44 [PATCH i-g-t v2 1/2] tests/kms_rotation_crc: move plane rotation requirements into helper Juha-Pekka Heikkila
2024-11-04 19:44 ` [PATCH i-g-t v2 2/2] tests/kms_rotation_crc: Intel display version 20 onwards doesn't do hflip with tile4 Juha-Pekka Heikkila
2024-11-06 10:54 ` Karthik B S [this message]
2024-11-04 21:07 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,v2,1/2] tests/kms_rotation_crc: move plane rotation requirements into helper Patchwork
2024-11-04 21:42 ` ✓ CI.xeBAT: " Patchwork
2024-11-05 13:03 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-11-05 16:51 ` ✗ CI.xeFULL: " Patchwork
2024-11-06 10:53 ` [PATCH i-g-t v2 1/2] " Karthik B S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0afc98a-338a-4a08-ba86-013b88f15f8d@intel.com \
--to=karthik.b.s@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox