public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Ramalingam C <ramalingam.c@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap: test for non pagealingned mmaps
Date: Mon, 8 Apr 2019 17:18:34 +0100	[thread overview]
Message-ID: <a102e4b7-4853-e0fc-fd9f-e5668a61c80e@linux.intel.com> (raw)
In-Reply-To: <155473982972.26510.15407723830372754424@skylake-alporthouse-com>


On 08/04/2019 17:10, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-08 17:01:00)
>>
>> On 08/04/2019 16:50, Ramalingam C wrote:
>>> Kernel supports the non page aligned mmaps. Hence this new subtest
>>
>> s/Kernel/i915/ to make Chris happy. Maybe also expand with "by mistake"
>> and clarify this applies only to CPU WC mmap flavour.

I need to correct myself, it applies to all CPU mmap flavours. So the 
test would need to test both strictly speaking.

>>
>> Unless Chris is objecting to testing this to start with?
> 
> Correct. This is not behaviour we expect to be enshrined in the ABI for
> future generations.

One could argue that since vm_mmap silently aligns it is the Linux ABI. 
And we did have an user report for the regression.

But if we have reached another impasse, my suggestion is that Ram just 
closes the assigned ticked with RESOLVED/WONTFIX, references the mailing 
list discussion, and moves on. It's not worth the hassle.

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-04-08 16:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-08 15:50 [igt-dev] [PATCH i-g-t] tests/i915/gem_mmap: test for non pagealingned mmaps Ramalingam C
2019-04-08 15:52 ` Chris Wilson
2019-04-08 16:01   ` C, Ramalingam
2019-04-08 16:01 ` Tvrtko Ursulin
2019-04-08 16:10   ` Chris Wilson
2019-04-08 16:18     ` Tvrtko Ursulin [this message]
2019-04-08 17:17 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-08 20:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a102e4b7-4853-e0fc-fd9f-e5668a61c80e@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ramalingam.c@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox