From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id B19E210E049 for ; Wed, 6 Dec 2023 04:38:11 +0000 (UTC) Message-ID: Date: Wed, 6 Dec 2023 10:08:00 +0530 To: Rodrigo Vivi , References: <20231205213814.179963-1-rodrigo.vivi@intel.com> Content-Language: en-US From: "Sundaresan, Sujaritha" In-Reply-To: <20231205213814.179963-1-rodrigo.vivi@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/3] tests/intel/xe: Align change in the name of frequency sysfs attributes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 12/6/2023 3:08 AM, Rodrigo Vivi wrote: > Aligns with kernel commit ("drm/xe: Change the name of frequency sysfs attributes") > > Cc: Sujaritha Sundaresan > Signed-off-by: Rodrigo Vivi > --- > tests/intel/{xe_guc_pc.c => xe_gt_freq.c} | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > rename tests/intel/{xe_guc_pc.c => xe_gt_freq.c} (98%) > > diff --git a/tests/intel/xe_guc_pc.c b/tests/intel/xe_gt_freq.c > similarity index 98% > rename from tests/intel/xe_guc_pc.c > rename to tests/intel/xe_gt_freq.c > index 3376e838f..a92833acb 100644 > --- a/tests/intel/xe_guc_pc.c > +++ b/tests/intel/xe_gt_freq.c > @@ -37,7 +37,7 @@ static int set_freq(int fd, int gt_id, const char *freq_name, uint32_t freq) > char freq_attr[16]; > int gt_fd; > > - snprintf(freq_attr, sizeof(freq_attr), "freq_%s", freq_name); > + snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name); > gt_fd = xe_sysfs_gt_open(fd, gt_id); > igt_assert(gt_fd >= 0); > > @@ -55,7 +55,7 @@ static uint32_t get_freq(int fd, int gt_id, const char *freq_name) > char freq_attr[16]; > int gt_fd; > > - snprintf(freq_attr, sizeof(freq_attr), "freq_%s", freq_name); > + snprintf(freq_attr, sizeof(freq_attr), "%s_freq", freq_name); > gt_fd = xe_sysfs_gt_open(fd, gt_id); > igt_assert(gt_fd >= 0); > This should be good to go in once the kernel changes have been merged. LGTM. Reviewed-by: Sujaritha Sundaresan