From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Eero Tamminen <eero.t.tamminen@intel.com>,
3.14pi@ukr.net, Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [IGT] tools/intel_gpu_top: Add support for stdout logging
Date: Fri, 8 Feb 2019 11:06:31 +0000 [thread overview]
Message-ID: <a1c5a2a3-87dc-ac13-3611-05986319f938@linux.intel.com> (raw)
In-Reply-To: <154962346180.3378.4416167999638397212@skylake-alporthouse-com>
On 08/02/2019 10:57, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-02-08 10:52:19)
>>
>> On 08/02/2019 10:33, Chris Wilson wrote:
>>> Quoting Tvrtko Ursulin (2019-02-08 10:26:12)
>>>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>>>
>>>> Two new output modes are added: listing of text data to standard out (-l
>>>> on the command line), and dumping of JSON formatted records (-J), also to
>>>> standard out.
>>>
>>> Any chance of interactive with yaml^W json to file?
>>
>> If you cannot do with shell redirection then sure, it shouldn't be hard
>> to add.
>>
>> YAML, if it follows the same patterns as JSON, also should be easy like
>> a handful of lines.
>>
>> And the latter.. I need some feedback from the users on how they plan to
>> use it. This implementation outputs records, but if you Ctrl-C-it you
>> get the last incomplete. And you probably need to wrap everything in [ ]
>> to make an array of these records.
>
> signal(SIGINT, close_output) ?
I guess.. wanted to keep it simple but this is probably warranted.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-08 11:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 10:26 [igt-dev] [IGT] tools/intel_gpu_top: Add support for stdout logging Tvrtko Ursulin
2019-02-08 10:33 ` Chris Wilson
2019-02-08 10:52 ` Tvrtko Ursulin
2019-02-08 10:57 ` Chris Wilson
2019-02-08 11:06 ` Tvrtko Ursulin [this message]
2019-02-08 10:48 ` Chris Wilson
2019-02-08 11:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-08 12:11 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-02-08 12:16 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1c5a2a3-87dc-ac13-3611-05986319f938@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=3.14pi@ukr.net \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=eero.t.tamminen@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox