From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: References: <20190322092155.1656-1-chris@chris-wilson.co.uk> <20190322092155.1656-15-chris@chris-wilson.co.uk> <68b853c9-970a-f901-cc5c-d9e5c796be35@linux.intel.com> <155360026777.15930.17162467336713467589@skylake-alporthouse-com> From: Tvrtko Ursulin Message-ID: Date: Tue, 26 Mar 2019 11:48:10 +0000 MIME-Version: 1.0 In-Reply-To: <155360026777.15930.17162467336713467589@skylake-alporthouse-com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 15/24] i915: Add gem_vm_create List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: igt-dev@lists.freedesktop.org List-ID: Ck9uIDI2LzAzLzIwMTkgMTE6MzcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTI2IDExOjIxOjEzKQo+Pgo+PiBPbiAyMi8wMy8yMDE5IDA5OjIx LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiArc3RhdGljIHZvaWQgaW52YWxpZF9jcmVhdGUoaW50 IGk5MTUpCj4+PiArewo+Pj4gKyAgICAgc3RydWN0IGRybV9pOTE1X2dlbV92bV9jb250cm9sIGN0 bCA9IHt9Owo+Pj4gKyAgICAgc3RydWN0IGk5MTVfdXNlcl9leHRlbnNpb24gZXh0ID0geyAubmFt ZSA9IC0xIH07Cj4+PiArCj4+PiArICAgICBpZ3RfYXNzZXJ0X2VxKF9fZ2VtX3ZtX2NyZWF0ZV9s b2NhbChpOTE1LCAmY3RsKSwgMCk7Cj4+PiArICAgICBnZW1fdm1fZGVzdHJveShpOTE1LCBjdGwu dm1faWQpOwo+Pj4gKwo+Pj4gKyAgICAgY3RsLnZtX2lkID0gMHhkZWFkYmVlZjsKPj4+ICsgICAg IGlndF9hc3NlcnRfZXEoX19nZW1fdm1fY3JlYXRlX2xvY2FsKGk5MTUsICZjdGwpLCAwKTsKPj4+ ICsgICAgIGdlbV92bV9kZXN0cm95KGk5MTUsIGN0bC52bV9pZCk7Cj4+PiArICAgICBjdGwudm1f aWQgPSAwOwo+Pgo+PiBPaCB3ZSBhbGxvdyBnYXJiYWdlIGluLi4gaG0uLiBwZXJoYXBzIGRpc2Fs bG93IHRoYXQ/Cj4gCj4gSXQncyBkb2N1bWVudGVkIGFzIGFuIG91dCBwYXJhbWV0ZXIsIHNvIG1l aC4KPiAKPj4gT3RoZXJ3aXNlIGJvdGggdGVzdHMgaGVyZSBhcmUgbm90IGludmFsaWQgaW5wdXQv YmVoYXZpb3VyLiBGaXJzdCBpcyBhbHNvCj4+IGNvdmVyZWQgYnkgaGFzX3ZtLgo+IAo+IEZpcnN0 IHRlc3QgaXMgd2l0aCB2YWxpZCBpbnB1dC4gU2Vjb25kIHRlc3QgY2hlY2tzIHRoYXQgd2UgZmls bCB0aGUKPiB2bV9pZCB3aXRoIHNvbWV0aGluZyByZWNvZ25pc2FibGUgYnkgdGhlIGtlcm5lbC4K PiAKPj4+ICsgICAgIGN0bC5mbGFncyA9IC0xOwo+Pj4gKyAgICAgaWd0X2Fzc2VydF9lcShfX2dl bV92bV9jcmVhdGVfbG9jYWwoaTkxNSwgJmN0bCksIC1FSU5WQUwpOwo+Pj4gKyAgICAgY3RsLmZs YWdzID0gMDsKPj4+ICsKPj4+ICsgICAgIGN0bC5leHRlbnNpb25zID0gLTE7Cj4+PiArICAgICBp Z3RfYXNzZXJ0X2VxKF9fZ2VtX3ZtX2NyZWF0ZV9sb2NhbChpOTE1LCAmY3RsKSwgLUVGQVVMVCk7 Cj4+PiArICAgICBjdGwuZXh0ZW5zaW9ucyA9IHRvX3VzZXJfcG9pbnRlcigmZXh0KTsKPj4+ICsg ICAgIGlndF9hc3NlcnRfZXEoX19nZW1fdm1fY3JlYXRlX2xvY2FsKGk5MTUsICZjdGwpLCAtRUlO VkFMKTsKPj4+ICsgICAgIGN0bC5leHRlbnNpb25zID0gMDsKPj4KPj4gQ291bGQgYWRkIGEgbG9v cCByZWplY3Rpb24gdGVzdCBhcyB3ZWxsLCBldmVuIHRob3VnaCB0aGUgdW5kZXJseWluZwo+PiBp bXBsZW1lbnRhdGlvbiBpcyBzaGFyZWQuCj4gCj4gQ2FuJ3QgbG9vcCBhcyB0aGVyZSBhcmUgbm8g dmFsaWQgZXh0ZW5zaW9ucyAoeWV0KSwgc28gaXQgZ2V0cyByZWplY3RlZCBieQo+IC1FSU5WQUwg Zm9yIHVucmVjb2duaXNlZCBuYW1lLgo+IAo+Pj4gK3N0YXRpYyB2b2lkIGludmFsaWRfZGVzdHJv eShpbnQgaTkxNSkKPj4+ICt7Cj4+PiArICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3ZtX2NvbnRy b2wgY3RsID0ge307Cj4+PiArCj4+PiArICAgICBpZ3RfYXNzZXJ0X2VxKF9fZ2VtX3ZtX2Rlc3Ry b3lfbG9jYWwoaTkxNSwgJmN0bCksIC1FTk9FTlQpOwo+Pgo+PiBTaG91bGQgd2UgaGF2ZSBpZCAw IGJlIC1FSU5WQUw/Cj4gCj4gVGhhdCB3b3VsZCBiZSBpbmNvbnNpc3RlbnQsIHNvIG5vLgoKT2su Cgo+Pj4gKyAgICAgaWd0X2Fzc2VydF9lcShfX2dlbV92bV9jcmVhdGVfbG9jYWwoaTkxNSwgJmN0 bCksIDApOwo+Pj4gKyAgICAgaWd0X2Fzc2VydF9lcShfX2dlbV92bV9kZXN0cm95X2xvY2FsKGk5 MTUsICZjdGwpLCAwKTsKPj4+ICsgICAgIGlndF9hc3NlcnRfZXEoX19nZW1fdm1fZGVzdHJveV9s b2NhbChpOTE1LCAmY3RsKSwgLUVOT0VOVCk7Cj4+PiArCj4+PiArICAgICBpZ3RfYXNzZXJ0X2Vx KF9fZ2VtX3ZtX2NyZWF0ZV9sb2NhbChpOTE1LCAmY3RsKSwgMCk7Cj4+PiArICAgICBjdGwudm1f aWQgPSBjdGwudm1faWQgKyAxOyAvKiBYWFggYXNzdW1lIGN5Y2xpYyBhbGxvY2F0b3IgKi8KPj4K Pj4gSSB0aGluayB0aGlzIGFjdHVhbGx5IGFzc3VtZXMsIGFuZCBjb3JyZWN0bHkgc28sIHRoYXQg dGhlIGZkIGlzIGNsZWFuCj4+IGllLiBvbmx5IHRoZSBjcmVhdGVkIHZtX2lkIGhhcyBiZWVuIGFs bG9jYXRlZC4gU28gY29tbWVudCBuZWVkcyB0byBiZQo+PiBjb3JyZWN0ZWQgSSB0aGluay4KPiAK PiBJdCB3YXMgbW9yZSB3aGF0IEkgd2FzIHBsYW5uaW5nIHRvIGRvLiBCdXQgeWVzLCB0aGUgYXNz dW1wdGlvbiBpcyB0aGF0Cj4gb25seSBvbmUgaWQgaXMgdmFsaWQuCj4gCj4+PiArICAgICBpZ3Rf YXNzZXJ0X2VxKF9fZ2VtX3ZtX2Rlc3Ryb3lfbG9jYWwoaTkxNSwgJmN0bCksIC1FTk9FTlQpOwo+ Pj4gKyAgICAgY3RsLnZtX2lkID0gY3RsLnZtX2lkIC0gMTsKPj4+ICsgICAgIGlndF9hc3NlcnRf ZXEoX19nZW1fdm1fZGVzdHJveV9sb2NhbChpOTE1LCAmY3RsKSwgMCk7Cj4+PiArCj4+PiArICAg ICBpZ3RfYXNzZXJ0X2VxKF9fZ2VtX3ZtX2NyZWF0ZV9sb2NhbChpOTE1LCAmY3RsKSwgMCk7Cj4+ PiArICAgICBjdGwuZmxhZ3MgPSAtMTsKPj4+ICsgICAgIGlndF9hc3NlcnRfZXEoX19nZW1fdm1f ZGVzdHJveV9sb2NhbChpOTE1LCAmY3RsKSwgLUVJTlZBTCk7Cj4+PiArICAgICBjdGwuZmxhZ3Mg PSAwOwo+Pj4gKyAgICAgaWd0X2Fzc2VydF9lcShfX2dlbV92bV9kZXN0cm95X2xvY2FsKGk5MTUs ICZjdGwpLCAwKTsKPj4KPj4gU2Vjb25kIGNyZWF0ZS1kZXN0cm95IGlzIHJlZHVuZGFudCBidXQg b2theS4KPiAKPiBSZWR1bmRhbnQgd2l0aCB3aGF0PwoKRm9yZ2V0IEkgc2FpZCBpdC4KCj4+PiAr ICAgICBpZ3RfYXNzZXJ0X2VxKF9fZ2VtX3ZtX2NyZWF0ZV9sb2NhbChpOTE1LCAmY3RsKSwgMCk7 Cj4+PiArICAgICBjdGwuZXh0ZW5zaW9ucyA9IC0xOwo+Pj4gKyAgICAgaWd0X2Fzc2VydF9lcShf X2dlbV92bV9kZXN0cm95X2xvY2FsKGk5MTUsICZjdGwpLCAtRUlOVkFMKTsKPj4+ICsgICAgIGN0 bC5leHRlbnNpb25zID0gMDsKPj4+ICsgICAgIGlndF9hc3NlcnRfZXEoX19nZW1fdm1fZGVzdHJv eV9sb2NhbChpOTE1LCAmY3RsKSwgMCk7Cj4+PiArfQo+Pj4gKwo+Pj4gK3N0YXRpYyB1aW50MzJf dCBfX2JhdGNoX2NyZWF0ZShpbnQgaTkxNSwgdWludDMyX3Qgb2Zmc2V0KQo+Pj4gK3sKPj4+ICsg ICAgIGNvbnN0IHVpbnQzMl90IGJiZSA9IE1JX0JBVENIX0JVRkZFUl9FTkQ7Cj4+PiArICAgICB1 aW50MzJfdCBoYW5kbGU7Cj4+PiArCj4+PiArICAgICBoYW5kbGUgPSBnZW1fY3JlYXRlKGk5MTUs IEFMSUdOKG9mZnNldCArIDQsIDQwOTYpKTsKPj4+ICsgICAgIGdlbV93cml0ZShpOTE1LCBoYW5k bGUsIG9mZnNldCwgJmJiZSwgc2l6ZW9mKGJiZSkpOwo+Pj4gKwo+Pj4gKyAgICAgcmV0dXJuIGhh bmRsZTsKPj4+ICt9Cj4+PiArCj4+PiArc3RhdGljIHVpbnQzMl90IGJhdGNoX2NyZWF0ZShpbnQg aTkxNSkKPj4+ICt7Cj4+PiArICAgICByZXR1cm4gX19iYXRjaF9jcmVhdGUoaTkxNSwgMCk7Cj4+ PiArfQo+Pgo+PiBPaSEgOkQKPj4KPj4+ICsKPj4+ICtzdGF0aWMgdm9pZCBleGVjYnVmKGludCBp OTE1KQo+Pj4gK3sKPj4+ICsgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY19vYmplY3QyIGJh dGNoID0gewo+Pj4gKyAgICAgICAgICAgICAuaGFuZGxlID0gYmF0Y2hfY3JlYXRlKGk5MTUpLAo+ Pj4gKyAgICAgfTsKPj4+ICsgICAgIHN0cnVjdCBkcm1faTkxNV9nZW1fZXhlY2J1ZmZlcjIgZWIg PSB7Cj4+PiArICAgICAgICAgICAgIC5idWZmZXJzX3B0ciA9IHRvX3VzZXJfcG9pbnRlcigmYmF0 Y2gpLAo+Pj4gKyAgICAgICAgICAgICAuYnVmZmVyX2NvdW50ID0gMSwKPj4+ICsgICAgIH07Cj4+ PiArICAgICBzdHJ1Y3QgZHJtX2k5MTVfZ2VtX2NvbnRleHRfcGFyYW0gYXJnID0gewo+Pj4gKyAg ICAgICAgICAgICAucGFyYW0gPSBJOTE1X0NPTlRFWFRfUEFSQU1fVk0sCj4+PiArICAgICB9Owo+ Pj4gKwo+Pj4gKyAgICAgLyogRmlyc3QgdmVyaWZ5IHRoYXQgd2UgdHJ5IHRvIHVzZSAic29mdHBp bm5pbmciIGJ5IGRlZmF1bHQgKi8KPj4+ICsgICAgIGJhdGNoLm9mZnNldCA9IDQ4IDw8IDIwOwo+ Pgo+PiBDaG9pY2Ugb2YgNDggaXMgYSBiaXQgbWlzbGVhZGluZywgYnV0IG9rYXkuCj4gCj4gTWlz bGVhZGluZz8gSXQncyBhIHNwb3QgaGFzIGEgZ29vZCBjaGFuY2Ugb2YgYmVpbmcgY2xlYXIgb24g ZXZlcnkKPiBwbGF0Zm9ybS4gSXQncyBhbG1vc3QgYXMgaWYgSSBqdXN0IGNvcGllZCB0aGlzIGZy b20gd2hlbiBJIHdhcyB0aGlua2luZwo+IGFib3V0IEdHVFQuCgpXaGF0IGlzIHNwZWNpYWwgYWJv dXQgNDhNaWI/IEFwYXJ0IHRoYXQgcmVtaW5kcyBtZSBvZiA0OC1iaXQgcHBndHQ/IDopCgpSZWdh cmRzLAoKVHZydGtvCgo+Pj4gKyAgICAgZ2VtX2V4ZWNidWYoaTkxNSwgJmViKTsKPj4+ICsgICAg IGlndF9hc3NlcnRfZXFfdTY0KGJhdGNoLm9mZnNldCwgNDggPDwgMjApOwo+Pj4gKwo+Pj4gKyAg ICAgYXJnLnZhbHVlID0gZ2VtX3ZtX2NyZWF0ZShpOTE1KTsKPj4+ICsgICAgIGdlbV9jb250ZXh0 X3NldF9wYXJhbShpOTE1LCAmYXJnKTsKPj4+ICsgICAgIGdlbV9leGVjYnVmKGk5MTUsICZlYik7 Cj4+PiArICAgICBpZ3RfYXNzZXJ0X2VxX3U2NChiYXRjaC5vZmZzZXQsIDQ4IDw8IDIwKTsKPj4K Pj4gTm90IHN1cmUgd2hhdCB0aGUgb2Zmc2V0IGNoZWNrIHByb3ZlcyBpbiB0aGlzIGNhc2U/IEl0 J3MgYSBuZXcgcHBndHQsIG9yCj4+IGV2ZW4gaWYgd2FzIG9sZCBvbmUuIFNlZW1zIGl0IHdvdWxk IG5ldmVyIGZhaWw/Cj4gCj4gUmlnaHQsIHRoaXMgaXMganVzdCBhbiB1bmFzc3VtaW5nIHZhbGlk IHBhdGgsIGNoZWNraW5nIHRoYXQgd2UgZm9sbG93Cj4gdGhlIGJhdGNoIG9mZnNldCBhcm91bmQs IGFuZCBleHBsb2RlcyBpZiB0aGUga2VybmVsIGZvcmdldHMgdG8gYWN0dWFsbHkKPiB1cGRhdGUg dGhlIFBEIGluc2lkZSB0aGUgY29udGV4dCBpbWFnZSBiZWZvcmUgZXhlY3V0aW9uLgo+IAo+IE5v dCB0aGF0IGhhcHBlbmVkLgo+IAo+Pj4gKyAgICAgZ2VtX3ZtX2Rlc3Ryb3koaTkxNSwgYXJnLnZh bHVlKTsKPj4+ICsKPj4+ICsgICAgIGFyZy52YWx1ZSA9IGdlbV92bV9jcmVhdGUoaTkxNSk7Cj4+ PiArICAgICBnZW1fY29udGV4dF9zZXRfcGFyYW0oaTkxNSwgJmFyZyk7Cj4+PiArICAgICBiYXRj aC5vZmZzZXQgPSAwOwo+Pj4gKyAgICAgZ2VtX2V4ZWNidWYoaTkxNSwgJmViKTsKPj4+ICsgICAg IGlndF9hc3NlcnRfZXFfdTY0KGJhdGNoLm9mZnNldCwgMCk7Cj4+PiArICAgICBnZW1fdm1fZGVz dHJveShpOTE1LCBhcmcudmFsdWUpOwo+Pj4gKwo+Pj4gKyAgICAgZ2VtX3N5bmMoaTkxNSwgYmF0 Y2guaGFuZGxlKTsKPj4+ICsgICAgIGdlbV9jbG9zZShpOTE1LCBiYXRjaC5oYW5kbGUpOwo+Pj4g K30KPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0 LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2