From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: matthew.auld@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t 3/4] tests/perf: new tests for OA interrupt
Date: Thu, 17 Jan 2019 11:03:48 +0000 [thread overview]
Message-ID: <a280afa8-d492-1788-900c-2fea03005661@intel.com> (raw)
In-Reply-To: <154768145819.9669.9168941470068870842@skylake-alporthouse-com>
On 16/01/2019 23:30, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2019-01-16 15:37:31)
>> + if (use_polling) {
>> + while ((ret = poll(&pollfd, 1, -1)) < 0 &&
>> + errno == EINTR)
>> + ;
> Hmm, are we sending signals to ourself? Just wondering if EINTR here is
> a kernel bug...
Hmm nope. I just assumed anything could interrupt us.
I think igt_ioctl() does the same right?
>
>> + igt_assert_eq(ret, 1);
>> + igt_assert(pollfd.revents & POLLIN);
>> + }
>> +
>> + while ((ret = read(stream_fd, buf, MAX_OA_BUF_SIZE)) < 0 &&
>> + errno == EINTR)
>> + ;
>> +
>> + if (ret < 0)
>> + igt_debug("Unexpected error when reading after poll = %d\n", errno);
>> + igt_assert_neq(ret, -1);
> igt_assert_f(ret != -1,
> "Unexpected error when reading after poll, %m\n");
> -Chris
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-01-17 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 15:37 [igt-dev] [PATCH i-g-t 0/4] tests/perf: Add new tests for enabling the OA interrupt Lionel Landwerlin
2019-01-16 15:37 ` [igt-dev] [PATCH i-g-t 1/4] bump headers Lionel Landwerlin
2019-01-16 15:37 ` [igt-dev] [PATCH i-g-t 2/4] tests/perf: new tests for parameterized OA buffer polling Lionel Landwerlin
2019-01-16 15:37 ` [igt-dev] [PATCH i-g-t 3/4] tests/perf: new tests for OA interrupt Lionel Landwerlin
2019-01-16 23:30 ` Chris Wilson
2019-01-17 11:03 ` Lionel Landwerlin [this message]
2019-01-17 11:26 ` Chris Wilson
2019-01-16 15:37 ` [igt-dev] [PATCH i-g-t 4/4] tests/perf: add flush data ioctl test Lionel Landwerlin
2019-01-16 21:50 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf: Add new tests for enabling the OA interrupt Patchwork
2019-01-16 23:55 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a280afa8-d492-1788-900c-2fea03005661@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox